-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect handling of trajectory endpoints #13
Comments
|
|
elmirjagudin
pushed a commit
to modelon/csv-compare
that referenced
this issue
Jul 11, 2016
Extrapolating the Y-value horizontally leads to false positives for curves with hight derivative twords the end of the curve. Take the reference curve's slope when calculating tube's end-points. Solves modelica-tools#13
elmirjagudin
pushed a commit
to modelon/csv-compare
that referenced
this issue
Jul 15, 2016
Extrapolating the Y-value horizontally leads to false positives for curves with hight derivative twords the end of the curve. Take the reference curve's slope when calculating tube's end-points. Solves modelica-tools#13
Hi ghost, This is indeed a problem we have been thinking about. However, there're several reasons not to simply extrapolate the last slope when computing the polygonal chain. please check out thomas' response to this pull request. We are, however, planning on adding a command line flag to enable pretty much what you have described. However, I cannot give you a time frame yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have been seeing some issues with the false-negatives in the endpoints of some trajectory comparisons. It usually happens when the signal have a "high" derivative.
For example:
You can see that the bounds calculation doesn't account for the derivative of the trajectory at the end point. The two results are very close and should be accepted.
Example files can be found here:
https://gist.github.com/jon-modelon/656e05349415bb2776a8
Command:
Version:
The text was updated successfully, but these errors were encountered: