-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly handle reference files with shorter time span than simulation StopTime #65
Comments
15 tasks
beutlich
added a commit
that referenced
this issue
Sep 17, 2024
beutlich
added a commit
that referenced
this issue
Sep 17, 2024
beutlich
added a commit
that referenced
this issue
Sep 20, 2024
beutlich
added a commit
that referenced
this issue
Sep 23, 2024
beutlich
added a commit
that referenced
this issue
Sep 23, 2024
beutlich
added a commit
that referenced
this issue
Sep 23, 2024
beutlich
added a commit
that referenced
this issue
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some models in the MSL show chaotic motion. It's good to see the chaotic motion in the simulation, so we set StopTime long enough to see that, but when issuing reference results, these should be computed on a time span which is short enough to avoid bifurcations and the onset of chaos, which is theoretically impossible to match with finite-precision numerical integration.
An easy solution to this problem is to generate reference files that are truncated to a shorter end time than the StopTime annotation of the model.
In this case, the CSV compare tool should only compare the trajectories over the time span that overlaps both the simulation results and the reference file. It already kind of does it, but the tubes at the end of the reference file time span are warped, so the test fails. See #4341
This should be fixed.
Keeping @beutlich and @GallLeo in the loop.
The text was updated successfully, but these errors were encountered: