Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My remarks after quick check #1

Open
tbeu opened this issue Mar 6, 2014 · 2 comments
Open

My remarks after quick check #1

tbeu opened this issue Mar 6, 2014 · 2 comments

Comments

@tbeu
Copy link

tbeu commented Mar 6, 2014

  1. I like to have keywords in blue (ok), strings in red and comment is green. Kind of common sense for most editors.
  2. Do you know dtsyntax: https://dtsyntax.googlecode.com/files/dtsyntax.pdf ?
  3. Commentstyle is missing. It simply does not look good in italics.
  4. Keyword 'within' is missing.
  5. What about builtin math functions: abs, sin, cos, etc. ?
  6. What about special functions semiLinear, smooth, noEvent, pre, change etc. ?
  7. What about array functions: size, vector, matrix, cross, outerProduct, skew, cat, fill etc. ?
@dietmarw
Copy link
Contributor

dietmarw commented Mar 7, 2014

Thanks for the input. All the enhancements make sense and will hopefully be integrated over time (or we get some pull requests ;-)). Basically this is just a first version and my hope is to extend it over time to something awesome.

The colour scheme might also be a matter of taste but perhaps we can have some themes where people can switch.

As to dtsyntax, I'm aware of it and have looked at it. There are some problems with it:

  1. It does not come with a license which basically means I'm not allowed to do anything with it except use it. So I can not add features or change it and publish it afterwards for others.
  2. The threshold of having to edit a LaTeX style file is somewhat higher than simply looking at the listings documentation and editing the config file directly. Having to install a package means some extra work on the user side especially when a simple \input{listings-modelica.cfg} does the same trick.

@dietmarw
Copy link
Contributor

dietmarw commented Mar 7, 2014

I stand corrected, the homepage of dtsyntax says actually GPL3. It was just not mentioned in the package file itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants