From c188727ae4f0cf9671b877534fb568d9213d6969 Mon Sep 17 00:00:00 2001 From: HOS Date: Mon, 9 Dec 2024 10:21:32 +0100 Subject: [PATCH 1/6] More or less according to decision. Introducing a name for it to make it easier to refer to, and to break up the long sentence. Closes #3613 --- chapters/annotations.tex | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/chapters/annotations.tex b/chapters/annotations.tex index 7aec8bf8b..c6a13be39 100644 --- a/chapters/annotations.tex +++ b/chapters/annotations.tex @@ -888,6 +888,11 @@ \subsection{Component Instance}\label{component-instance} Sub-connectors in a hierarchical connector are only shown when they can be connected to. Non-connector components are only shown in the diagram layer. +\subsubsection{Default Outline for Missing Graphics}\label{default-outline-for-missing-graphics} +If the icon of a class does not contain any graphical primitives (including inherited ones, and regardless of visibility; but excluding connectors) it is said to be missing graphics. +If the icon of a class used in a diagram is missing graphics then tools shall show a tool-dependent outline of the extent of the component to make improve usability. +The model with missing graphics should be updated if its icon is used in any diagram. + \subsection{Extends-Clause}\label{extends-clause} Each \lstinline!extends!-clause (and short class definition, as stated in \cref{annotations-for-graphical-objects}) may have layer specific annotations which describe the rendering of the base class' icon and diagram layers in the derived class. From a27e9eb78838f84ee76b8b0edf3cc3f73e9ca022 Mon Sep 17 00:00:00 2001 From: Hans Olsson Date: Mon, 9 Dec 2024 10:28:29 +0100 Subject: [PATCH 2/6] Update chapters/annotations.tex --- chapters/annotations.tex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chapters/annotations.tex b/chapters/annotations.tex index c6a13be39..975bba5bb 100644 --- a/chapters/annotations.tex +++ b/chapters/annotations.tex @@ -890,7 +890,7 @@ \subsection{Component Instance}\label{component-instance} \subsubsection{Default Outline for Missing Graphics}\label{default-outline-for-missing-graphics} If the icon of a class does not contain any graphical primitives (including inherited ones, and regardless of visibility; but excluding connectors) it is said to be missing graphics. -If the icon of a class used in a diagram is missing graphics then tools shall show a tool-dependent outline of the extent of the component to make improve usability. +If the icon of a class used in a diagram is missing graphics then tools shall show a tool-dependent outline of the extent of the component to improve usability. The model with missing graphics should be updated if its icon is used in any diagram. \subsection{Extends-Clause}\label{extends-clause} From 86921e6f9ee1afd02195581465fed4e49d67e675 Mon Sep 17 00:00:00 2001 From: Hans Olsson Date: Wed, 11 Dec 2024 14:08:35 +0100 Subject: [PATCH 3/6] Update chapters/annotations.tex Co-authored-by: Henrik Tidefelt --- chapters/annotations.tex | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/chapters/annotations.tex b/chapters/annotations.tex index 975bba5bb..d5564215a 100644 --- a/chapters/annotations.tex +++ b/chapters/annotations.tex @@ -889,8 +889,11 @@ \subsection{Component Instance}\label{component-instance} Non-connector components are only shown in the diagram layer. \subsubsection{Default Outline for Missing Graphics}\label{default-outline-for-missing-graphics} -If the icon of a class does not contain any graphical primitives (including inherited ones, and regardless of visibility; but excluding connectors) it is said to be missing graphics. -If the icon of a class used in a diagram is missing graphics then tools shall show a tool-dependent outline of the extent of the component to improve usability. +If the icon of a component placed in a diagram layer does not contain any graphical primitives (including inherited ones, and regardless of visibility; but excluding connectors), tools shall show a tool-dependent rudimentary outline of the component's transformed \lstinline!extent!. + +\begin{nonnormative} +The reason for making the tool-dependent outline rudimentary is to encourage the model developer to provide a proper icon. +\end{nonnormative} The model with missing graphics should be updated if its icon is used in any diagram. \subsection{Extends-Clause}\label{extends-clause} From 2a5e3f25b43163055989deef952bbba47becde7e Mon Sep 17 00:00:00 2001 From: Hans Olsson Date: Wed, 11 Dec 2024 14:08:43 +0100 Subject: [PATCH 4/6] Update chapters/annotations.tex Co-authored-by: Henrik Tidefelt --- chapters/annotations.tex | 1 - 1 file changed, 1 deletion(-) diff --git a/chapters/annotations.tex b/chapters/annotations.tex index d5564215a..35c948b20 100644 --- a/chapters/annotations.tex +++ b/chapters/annotations.tex @@ -894,7 +894,6 @@ \subsubsection{Default Outline for Missing Graphics}\label{default-outline-for-m \begin{nonnormative} The reason for making the tool-dependent outline rudimentary is to encourage the model developer to provide a proper icon. \end{nonnormative} -The model with missing graphics should be updated if its icon is used in any diagram. \subsection{Extends-Clause}\label{extends-clause} From 179a6f5a0634bf09fdcf491bbbf34575ebb4a412 Mon Sep 17 00:00:00 2001 From: Hans Olsson Date: Wed, 11 Dec 2024 17:34:42 +0100 Subject: [PATCH 5/6] Apply suggestions from code review Co-authored-by: Henrik Tidefelt --- chapters/annotations.tex | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/chapters/annotations.tex b/chapters/annotations.tex index 35c948b20..d00ef5a18 100644 --- a/chapters/annotations.tex +++ b/chapters/annotations.tex @@ -889,10 +889,11 @@ \subsection{Component Instance}\label{component-instance} Non-connector components are only shown in the diagram layer. \subsubsection{Default Outline for Missing Graphics}\label{default-outline-for-missing-graphics} -If the icon of a component placed in a diagram layer does not contain any graphical primitives (including inherited ones, and regardless of visibility; but excluding connectors), tools shall show a tool-dependent rudimentary outline of the component's transformed \lstinline!extent!. +If the icon of a component placed in a diagram layer does not contain any graphical primitives (including inherited ones, and regardless of \lstinline!visible!-attributes; but excluding connectors), tools shall show a tool-dependent rudimentary outline of the component's transformed \lstinline!extent!. \begin{nonnormative} The reason for making the tool-dependent outline rudimentary is to encourage the model developer to provide a proper icon. +Regardless of \lstinline!visible!-attributes imply that if the primitives have a parameter-dependent value for \lstinline!visible! or even \lstinline!visible = false! it will not switch to the default icon regardless of the parameter setting. \end{nonnormative} \subsection{Extends-Clause}\label{extends-clause} From dd846d843243e123535ad8e11feacceaedca78ff Mon Sep 17 00:00:00 2001 From: HOS Date: Tue, 17 Dec 2024 13:49:36 +0100 Subject: [PATCH 6/6] Shorter. --- chapters/annotations.tex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chapters/annotations.tex b/chapters/annotations.tex index d00ef5a18..a7896f30c 100644 --- a/chapters/annotations.tex +++ b/chapters/annotations.tex @@ -893,7 +893,7 @@ \subsubsection{Default Outline for Missing Graphics}\label{default-outline-for-m \begin{nonnormative} The reason for making the tool-dependent outline rudimentary is to encourage the model developer to provide a proper icon. -Regardless of \lstinline!visible!-attributes imply that if the primitives have a parameter-dependent value for \lstinline!visible! or even \lstinline!visible = false! it will not switch to the default icon regardless of the parameter setting. +Regardless of \lstinline!visible!-attributes imply that all primitives are considered regardless of the value of their \lstinline!visible!-attribute. \end{nonnormative} \subsection{Extends-Clause}\label{extends-clause}