Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class name as text in Diagram in Electrical.Analog #4186

Open
maltelenz opened this issue Aug 31, 2023 · 2 comments
Open

Class name as text in Diagram in Electrical.Analog #4186

maltelenz opened this issue Aug 31, 2023 · 2 comments
Assignees
Labels
example Issue only addresses example(s) L: Electrical.Analog Issue addresses Modelica.Electrical.Analog

Comments

@maltelenz
Copy link
Contributor

maltelenz commented Aug 31, 2023

A lot of the examples in Modelica.Electrical.Analog.Examples have a large Text item on the Diagram basically replicating the information of the class name.

Other sub-libraries in MSL don't have this, and any tool would presumably show the class name somewhere close when showing the diagram, so replicating this information on the diagram only adds clutter.

Would a pull request removing these Text items be accepted?

@maltelenz maltelenz added the L: Electrical.Analog Issue addresses Modelica.Electrical.Analog label Aug 31, 2023
@beutlich beutlich added the example Issue only addresses example(s) label Sep 4, 2023
@HansOlsson
Copy link
Contributor

It is also inconsistently done in that package; which makes it less useful.

However, note that even if Modelica.Electrical.Analog.Examples.ResonanceCircuits has texts in a similar style I think they should be kept (and such texts should be encouraged), whereas Modelica.Electrical.Analog.Examples.ShowVariableResistor has a text that is roughly the class name.

@maltelenz
Copy link
Contributor Author

It is also inconsistently done in that package; which makes it less useful.

However, note that even if Modelica.Electrical.Analog.Examples.ResonanceCircuits has texts in a similar style I think they should be kept (and such texts should be encouraged), whereas Modelica.Electrical.Analog.Examples.ShowVariableResistor has a text that is roughly the class name.

I agree with everything you say here. There are definitely cases where text on diagrams can be used for good things, like in ResonanceCircuits. I would not want to remove those cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
example Issue only addresses example(s) L: Electrical.Analog Issue addresses Modelica.Electrical.Analog
Projects
None yet
Development

No branches or pull requests

5 participants