Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSL v4.1.0-beta.1 feedback: Example name inconsistency #4329

Open
beutlich opened this issue Feb 21, 2024 · 4 comments
Open

MSL v4.1.0-beta.1 feedback: Example name inconsistency #4329

beutlich opened this issue Feb 21, 2024 · 4 comments
Assignees
Labels
example Issue only addresses example(s)
Milestone

Comments

@beutlich
Copy link
Member

beutlich commented Feb 21, 2024

This is the topic split of #4304 where I wondered why some of the new example models are called _Demo_Something and others _Demonstrate_Something. One idea was to get rid of this Demo/Demonstrate prefix.

@beutlich beutlich added the example Issue only addresses example(s) label Feb 21, 2024
@beutlich beutlich added this to the MSL4.1.0 milestone Feb 21, 2024
@AHaumer AHaumer modified the milestones: MSL4.1.0, MSL4.2.0 Feb 11, 2025
@AHaumer
Copy link
Contributor

AHaumer commented Feb 11, 2025

Shift to next release sinve this is cosmetics

@beutlich
Copy link
Member Author

beutlich commented Feb 11, 2025

No, renaming example models is not just cosmetics as it effects the regression testing. Not having the proper names now will certainly lead to unexpected regression evaluations later (missing result -> new result).

@maltelenz
Copy link
Contributor

missing result -> new result

If a model is renamed, the result files should just be renamed as well, not generated from scratch.
This step needs to be taken regardless of if it's done now or for 4.2.0.

I agree with @AHaumer, we have to stop doing things for 4.1.0 to ever get it released.

@tobolar
Copy link
Contributor

tobolar commented Feb 12, 2025

I usually try to omit "Demo" in model names since each example is principally demonstrating some model's feature, right? So to me it is generally a bad practice which should be omitted if possible in the future. (And yes, I myself sometimes indeed use "demo" for lack of better ideas.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
example Issue only addresses example(s)
Projects
None yet
Development

No branches or pull requests

4 participants