-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSL 4.1.0 Reference results for new models #4349
Comments
Sure. Already available at https://github.com/beutlich/MAP-LIB_ReferenceResults for patched v4.1.0-beta.1. |
After spending some more time on #4343 I only noticed now that some of the simulation result is no longer reproducable. Not sure what I did then (beside the too much manual patching). In order not to use it I removed that fork for now. Sorry for the inconvenience. |
These models are missing a corresponding
|
Confirmed, see #3679 for the first and #3959 for the other two. I actually wonder why I missed them for #4304. (Edit: Fixed by modelica-tools/msl-release@71b4d6a) @AHaumer @casella This needs to be fixed before tagging a new release. |
For the two new dynamic pipe check models, I opened PR #4425. Once accepted, it need to be back-ported to maint/4.1.0 before closing this ticket. |
@Esther-Devakirubai can you also please backport #4423, adding the same reviewers as the original PR? Thanks! |
Done by #4454 . Thanks |
MSL 4.1.0 comes with new example models compared to 4.0.0.
These need new reference results at https://github.com/modelica/MAP-LIB_ReferenceResults/tree/v4.1.0
List of new models:
The text was updated successfully, but these errors were encountered: