Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FundamentalWavePermabilitySensor is misspelled #4400

Open
JoeRiel opened this issue Apr 29, 2024 · 2 comments
Open

FundamentalWavePermabilitySensor is misspelled #4400

JoeRiel opened this issue Apr 29, 2024 · 2 comments
Assignees
@christiankral @AHaumer
Labels
L: Magnetic.QuasiStatic Issue addresses Modelica.Magnetic.QuasiStatic

Comments

@JoeRiel
Copy link
Contributor

JoeRiel commented Apr 29, 2024

Modelica.Magnetic.QuasiStatic.FluxTubes.Sensors.Transient.FundamentalWavePermabilitySensor is misspelled, the base name should be FundamentalWavePermeabilitySensor.
@maltelenz maltelenz added the L: Magnetic.QuasiStatic Issue addresses Modelica.Magnetic.QuasiStatic label Apr 30, 2024
@AHaumer
Copy link
Contributor

AHaumer commented Jul 2, 2024

Should we correct that now? Name change is not backwards compatible.

@casella
Copy link
Contributor

casella commented Jul 2, 2024

I would avoid non-backwards compatible changes. We could make a copy of the component with the correctly spelled name and keep the existing one with a deprecated icon for backwards compatibility.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christiankral christiankral

@AHaumer AHaumer

Labels
L: Magnetic.QuasiStatic Issue addresses Modelica.Magnetic.QuasiStatic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@JoeRiel @maltelenz @christiankral @casella @AHaumer