Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modelica.Magnetic.FluxTubes examples - comment from #4418 #4431

Open
HansOlsson opened this issue Jun 28, 2024 · 2 comments
Open

Modelica.Magnetic.FluxTubes examples - comment from #4418 #4431

HansOlsson opened this issue Jun 28, 2024 · 2 comments
Assignees
Labels
L: Magnetic.FluxTubes Issue addresses Modelica.Magnetic.FluxTubes
Milestone

Comments

@HansOlsson
Copy link
Contributor

HansOlsson commented Jun 28, 2024

Two issues for Modelica.Magnetic.FluxTubes.Examples.MovingCoilActuator.ForceCurrentBehaviour and Modelica.Magnetic.FluxTubes.Examples.MovingCoilActuator.ForceStrokeBehaviour:

  1. I don't see why we have so short Interval (1e-4) for these two models in Resolve #4336 #4418

To me it seems 0.01 s would work as well, and if someone sets a very small Interval I expect that there is something relevant on that time-scale, and I don't know which signal. So, if there is something interesting on that time-scale, please enlighten me. (Note that Modelica.Magnetic.FluxTubes.Examples.MovingCoilActuator.ArmatureStroke has a small Interval since it simulates for a short time and has interesting dynamics.)

  1. The documentation is broken for those two models (and likely have been for quite some time) - it refers to flange_b for components that only have flange.

Originally posted by @HansOlsson in #4418 (review)

@HansOlsson HansOlsson added the L: Magnetic.FluxTubes Issue addresses Modelica.Magnetic.FluxTubes label Jun 28, 2024
@casella casella added this to the MSL4.1.0 milestone Jun 28, 2024
@casella
Copy link
Contributor

casella commented Jun 28, 2024

@AHaumer can you please commen on that?

@AHaumer
Copy link
Contributor

AHaumer commented Jul 2, 2024

I just compared two simulations and yes 100 ms is ok.
We just have to take care of the reference results ...
I'll have a look at the broken links.

@beutlich beutlich changed the title Modelica.Magnetic.FluxTubes examples - comment from 4418 Modelica.Magnetic.FluxTubes examples - comment from #4418 Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: Magnetic.FluxTubes Issue addresses Modelica.Magnetic.FluxTubes
Projects
None yet
Development

No branches or pull requests

3 participants