Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update matio for MSL 4.1.0 #4489

Open
casella opened this issue Oct 25, 2024 · 7 comments · May be fixed by #4531
Open

Update matio for MSL 4.1.0 #4489

casella opened this issue Oct 25, 2024 · 7 comments · May be fixed by #4531
Assignees
@beutlich
Labels
L: C-Sources Issue addresses Modelica/Resources/C-Sources
Milestone
MSL4.1.0

Comments

@casella
Copy link
Contributor

casella commented Oct 25, 2024 •
edited
Loading

Following the discussion in #4480, I think we should update matio in MSL 4.1.0 to the latest version, to avoid shipping a library with known vulnerabilities. The latest version of matio merged into MSL 4.1.0 was 1.5.24, November last year.

MSL 4.1.0 misses the two latest updates, 1.5.26, which was merged on master on March 28 in #4285 but not back-ported to main/4.1.x, and 1.5.27. If we merge them on maint/4.1.x, we should also re-build the matio binary, since we agreed to still ship the binaries with the MSL for 4.1.0.

Considering the delay in releasing 4.1.0, due to the awkward regression testing process, I think there's no reason to not include them in the 4.1.0 release. We are still not done with regression testing, and the likelyhood that this update introduces some new regressions is very small, so that's not going to be disruptive.

@beutlich what do you think? Could you prepare a PR which updates matio and the matio binaries to 1.5.27 on maint/4.1.x?

If we see that it causes regressions, we can always roll it back.
@casella casella added the L: ModelicaServices Issue addresses ModelicaServices label Oct 25, 2024
@casella casella added this to the MSL4.1.0 milestone Oct 25, 2024
@casella casella mentioned this issue Oct 25, 2024
Merged
@beutlich
Copy link
Member

beutlich commented Oct 25, 2024 •
edited by casella
Loading

#4455 is the appropriate PR for master. EDIT: superseded by #4497. This is just the sources, not the binaries, because there still is #4347 open.

@beutlich beutlich added L: C-Sources Issue addresses Modelica/Resources/C-Sources and removed L: ModelicaServices Issue addresses ModelicaServices labels Oct 25, 2024
@casella
Copy link
Contributor Author

casella commented Nov 11, 2024

@beutlich do you think you can provide the binaries for MSL 4.1.0? Otherwise, we'll keep whatever version of MatIO we had when you last built the binaries.

@beutlich
Copy link
Member

Can do, but which branch or which PR?.

@casella
Copy link
Contributor Author

casella commented Nov 11, 2024

In 4.1.0 we decided to still keep the compiled binaries in the git repo. As I understand this would require to

But maybe I missed the point of your question?

@beutlich
Copy link
Member

beutlich commented Jan 2, 2025

@casella I am still waiting for your review on #4506 to finally move on with this back-port issue.

@casella
Copy link
Contributor Author

casella commented Feb 11, 2025

@beutlich we approved #4506. Please proceed with back-porting of #4497 and #4506 to maint/4.1.x.

@beutlich
Copy link
Member

@beutlich we approved #4506. Please proceed with back-porting of #4497 and #4506 to maint/4.1.x.

Done by #4531. Also #4285 needed to be back-ported.

@beutlich beutlich linked a pull request Feb 11, 2025 that will close this issue
Update matio library to 1.5.28 #4531
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beutlich beutlich

Labels
L: C-Sources Issue addresses Modelica/Resources/C-Sources
Projects
None yet
Milestone
MSL4.1.0
Development

Successfully merging a pull request may close this issue.

Update matio library to 1.5.28 beutlich/ModelicaStandardLibrary
2 participants
@casella @beutlich