Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove function dorgqr_x #191

Open
tobolar opened this issue Apr 16, 2024 · 1 comment
Open

Remove function dorgqr_x #191

tobolar opened this issue Apr 16, 2024 · 1 comment
Labels
p::Math.Matrices Issue concerns M_LS2.Math.Matrices wontfix

Comments

@tobolar
Copy link
Collaborator

tobolar commented Apr 16, 2024

Function M_LS2.Math.Matrices.LAPACK.dorgqr_x shall be replaced with Modelica.Math.Matrices.LAPACK.dormqr. But modelica/ModelicaStandardLibrary#4388 shall be resolved first since otherwise the new function call would look like:
Modelica.Math.Matrices.LAPACK.dormqr(Q, Q, tau, "L", "N"), i.e. with doubled input of Q, which is odd.

@tobolar tobolar added the p::Math.Matrices Issue concerns M_LS2.Math.Matrices label Apr 16, 2024
@tobolar
Copy link
Collaborator Author

tobolar commented Apr 17, 2024

It seems the following replacement could be possible:

(Aout, info) := Modelica.Math.Matrices.LAPACK.dormqr(A, Q, tau, "L", "N");

instead of

(Aout, info) := Modelica_LinearSystems2.Math.Matrices.LAPACK.dorgqr_x(Q, tau);

with a predecessor (in both cases)

(Q, tau, info, work) := Modelica.Math.Matrices.LAPACK.dgeqrf(A);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p::Math.Matrices Issue concerns M_LS2.Math.Matrices wontfix
Projects
None yet
Development

No branches or pull requests

1 participant