Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec should give more leeway in the default address/port in A2L/interface #16

Closed
pmai opened this issue May 9, 2023 · 3 comments
Closed
Assignees

Comments

@pmai
Copy link
Collaborator

pmai commented May 9, 2023

Currently the spec states:

The default IP address assigned by the FMU exporter shall be localhost, i.e. 127.0.0.1, which fits in many cases. 

This should be loosened a bit, since there are use cases where the XCP service of the FMU runs on a specific machine (e.g. in the cases of FMU remoting or other forms of FMU proxying, where the FMU running on the simulator only interfaces to the actual SW/FMU, and hence the XCP slave is also on that machine).

@andreas-junghanns
Copy link
Contributor

Also: the XCP section of the A2L file must contain consistent (equivalent?) information w.r.t. what that definition.

@PTaeuberDS PTaeuberDS assigned PTaeuberDS and pmai and unassigned PTaeuberDS May 24, 2023
PTaeuberDS added a commit to PTaeuberDS/fmi-ls-xcp that referenced this issue Jun 16, 2023
@PTaeuberDS PTaeuberDS assigned PTaeuberDS and unassigned pmai Jun 16, 2023
@PTaeuberDS
Copy link
Collaborator

Addressed in #26/#27, respectively.

@andreas-junghanns Not quite sure what your addition refers to. Maybe you can check/fix this by yourself.
At least for the port it is mentioned that it must be consistent throughout FMU/XCP slave configuration and A2L file.

@andreas-junghanns
Copy link
Contributor

andreas-junghanns commented Jun 16, 2023

Addressed in #26/#27, respectively.

@andreas-junghanns Not quite sure what your addition refers to. Maybe you can check/fix this by yourself. At least for the port it is mentioned that it must be consistent throughout FMU/XCP slave configuration and A2L file.

Inside the a2l file(s), the IP/Port combinations are also specified. What we define in the .xml file must not contradict the a2l definitions. -- just saw, this is taken care off by PR #26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants