Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification about changing variables org.fmi_standard.fmi_ls_xcp.EnableXcpOn[Tcp|Udp]Ip #47

Closed
paulfilip opened this issue Mar 19, 2024 · 0 comments · Fixed by #52
Closed
Assignees

Comments

@paulfilip
Copy link

The standard implies that In the case the XCP service is not multi-session capable and both of the variables org.fmi_standard.fmi_ls_xcp.EnableXcpOn[Tcp|Udp]Ip are set to true, the FMU must return an error in the corresponding setter function and provide a meaningful error message.
I think that the way variables are changed in Configuration Mode matters in this case.
For example, if by default the XCP is enabled on TCP and disabled on UDP and the user wants to make it vice versa, then one could

  1. set EnableXcpOnUdpIp to true
  2. set EnableXcpOnTcpIp to false

Although the final state is a valid one (only one of TCP/UDP is active), the intermediate state (when both variables are true) will cause the FMU to return with an error. A solution in this case is to reverse the commands 1 and 2 from above.
Would it be beneficial if this check will be performed later (e.g in exitConfigurationMode if the FMU does not support both protocols in parallel)?

@snps-ribbe snps-ribbe self-assigned this Mar 26, 2024
snps-ribbe added a commit that referenced this issue May 14, 2024
 Clarification about changing variables org.fmi_standard.fmi_ls_xcp.EnableXcpOn[Tcp|Udp]Ip #47
@andreas-junghanns andreas-junghanns linked a pull request May 14, 2024 that will close this issue
PTaeuberDS pushed a commit that referenced this issue May 14, 2024
 Clarification about changing variables org.fmi_standard.fmi_ls_xcp.EnableXcpOn[Tcp|Udp]Ip #47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants