Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustment to 'nominal' definition for arrays #1842

Open
Maplesoft-fmigroup opened this issue Dec 7, 2022 · 2 comments
Open

Adjustment to 'nominal' definition for arrays #1842

Maplesoft-fmigroup opened this issue Dec 7, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@Maplesoft-fmigroup
Copy link
Contributor

This is a non-backward compatible change for specification of 'nominal' values. Currently 'nominal' is defined as a scalar 'double'; however, one may want different 'nominal' values for each element of an array (as questionable as that may be). If we want to support such a change for 3.0.1 then we could use the same approach as for the 'start' field in arrays:
nominal = "1.0 1e5 1e5 100 100 100 1e5"

@Maplesoft-fmigroup Maplesoft-fmigroup added the enhancement New feature or request label Dec 7, 2022
@Maplesoft-fmigroup Maplesoft-fmigroup added this to the v3.0.1 milestone Dec 7, 2022
@chrbertsch chrbertsch removed this from the v3.0.1 milestone Dec 8, 2022
@klausschuch
Copy link
Collaborator

I don't think that we could change this is in a bugfix (3.0.x) version.
How would we handle arrays with sizes depending on structural parameters with variability fixed (or even tunable)?
The FMU could only provide the nominals for the start sizes.
I think, if we allow different nominal values for individual elements of an array, we would even need a function to get the nominals (similar to the functions for getting dependencies (fmi3GetVariableDependencies).

@Maplesoft-fmigroup
Copy link
Contributor Author

@klausschuch There already is a function for getting nominals at least for the states (fmi3GetNominalsOfContinuousStates). Since we already added a clarification to 3.0.1 that all array elements will get scaled by the same nominal value, this should 'encourage' users to vectorize compatible quantities only. Maybe we can postpone this feature until there is a specific use-case presented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants