Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-normative text states that importers can deactivate output clocks #1915

Open
PTaeuberDS opened this issue Dec 19, 2023 · 2 comments
Open
Assignees

Comments

@PTaeuberDS
Copy link
Contributor

In section 2.3.5. State: Event Mode in the description of the fmi3SetClock function the following example is given as non-normative text:

[Rationale: a triggered output Clock c may depend on some variable v that is involved in an algebraic loop. As part of the iterations to solve the algebraic loop, v acquires a value that activates the Clock. If the final (or some intermediate) value of v no longer activates the Clock, then this Clock must be deactivated by the Importer during the same super-dense time instant.]

This means the importer has to call fmi3SetClock on an output clock. But calling fmi3SetClock is only allowed for input clocks.

Maybe it should simply be changed to:
"... then this Clock must be deactivated by the Importer FMU during the ..."

@chrbertsch
Copy link
Collaborator

FMI Design Meeting:
Klaus: I think this is a reminder of a previous definition of clocks. (This might be a problem of our usage of "input" and "output" clocks, resp. "information flow")

@masoud-najafi
Copy link
Collaborator

The output clocks can only be Set internally by the FMU and be Get by the importer. This is just a typo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants