Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define matching rule "none" in the base FMI standard #1942

Closed
chrbertsch opened this issue May 14, 2024 · 2 comments · Fixed by #1976
Closed

Define matching rule "none" in the base FMI standard #1942

chrbertsch opened this issue May 14, 2024 · 2 comments · Fixed by #1976
Assignees
Milestone

Comments

@chrbertsch
Copy link
Collaborator

providing a matching rule is mandatory, see
There might be use cases where one does not want one of the predefined matching rules to be applied, see modelica/fmi-ls-struct#8

@chrbertsch chrbertsch added this to the v3.x milestone May 14, 2024
@chrbertsch
Copy link
Collaborator Author

FMI Webmeeting:

Christian: Could this be defined in 3.0.2?
KLaus: could be done technically, but does not sound like a bugfix.

@chrbertsch
Copy link
Collaborator Author

Pierre: I could live with this in 3.0.2. We are not really defining something new.
Klaus: It is a non-breaking change to make matching rule optional.
Pierrre: "none" is more than "do whatever you want", because it discourages doing something.
Klaus: the FMU tells "I do not know anything about matching".
Pierre: Could be the FMU/ layered standard author.
Klaus: "none" is undefined, "don't" would tell not to match.
Pierre: "none": for me means: do no automatic matching, "undefined": do whatever you want.
Klaus: in FMI-LS-STRUCT we defined a specific matching rule

Poll:
Do we want to add a new matching rule at all?
Yes: Pierre, Christian, Otto, Garron, Jan, Daniel
No: -
Abstain: Rest

Do we want as new matching rules:

  • "none" only ("the creator of the FMU does not intend automatic matching", under user direction the tool can do whatever it pleases): Nikolai, Kharamon, Pierre, Garron, Jan, Klaus
  • "none" and "undefined": Christian
  • Abstain: Rest

Pierre: "none" would also be a good default

@chrbertsch chrbertsch modified the milestones: v3.x, v3.0.2 Sep 10, 2024
@chrbertsch chrbertsch linked a pull request Sep 12, 2024 that will close this issue
@pmai pmai closed this as completed in #1976 Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants