Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on what is meant with " unique on each level" for the "name" attribute of a <Terminal> #1959

Open
TorstenBlochwitz opened this issue Jun 26, 2024 · 3 comments
Assignees

Comments

@TorstenBlochwitz
Copy link

TorstenBlochwitz commented Jun 26, 2024

In section 2.4.9.2.2 Terminals we wrote:

The normalized string attribute name of the "Terminal" element is the unique instance name of the terminal. The terminal name must be unique on each level.

Does that mean the "name" attribute must be unique w.r.t. to the "Terminals" list only, or does the 2nd sentence extent the uniqueness to the names of "ModelVariables" ?

I think we need a clarification here,

@chrbertsch
Copy link
Collaborator

@TorstenBlochwitz: do you want to clarify whether in a terminal with name "foo" you can have a contained terminal with the same name "foo"?

@TorstenBlochwitz
Copy link
Author

@chrbertsch : No, I want to clarify if is allowed to use the same "name" for a Terminal and a Variable.

In addition to that we should also clarify your case.

@chrbertsch
Copy link
Collaborator

FMI Design Webmeeting:
Pierre: I think the second sentence above refers to nested terminals
Torsten: For a Modelica Tool it would be strange and one would have to do effort to fix this issue.
Otto: There is also a sentence about the structured naming convention
Pierre: I think this does not forbid to have the same name
Torsten B.: If you have a terminal with name A, which a Terminal member variable "B", the name of the referenced variable does not have to have the name "A.B". We could add this sentence as non normative text.
Pierre, Torsten: Both solulations have problems for either importer or exporter. So we should fix it.
Otto: in Modelica there are connectors where the connector is the variable
Torsten B.: If you want to graphical information for an input that is no terminal, you should create a terminal that contains the variable
Pierre: I would not allow same variable names and terminals on the top level, because it could lead to problems in downstream technologies.
Torsten B.: We should consider if this has implications in FMI-LS-STRUCT
Torsten B.: I will look into this and ask him if he remembers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants