-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: streamline cluster analysis process #15
Open
sjungling
wants to merge
11
commits into
main
Choose a base branch
from
refactor/uv
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjungling
force-pushed
the
refactor/uv
branch
2 times, most recently
from
December 19, 2024 01:29
0db815d
to
ee9ad2f
Compare
consolidate python methods and treat the script as a CLI to help offer easier discoverability for how to either analyze local logs or remote logs from artifactory
sjungling
force-pushed
the
refactor/uv
branch
from
December 19, 2024 02:30
ee9ad2f
to
e10c11a
Compare
move from large to small model for embedding, fix issues with cleaning volume mounts
sjungling
force-pushed
the
refactor/uv
branch
2 times, most recently
from
December 19, 2024 21:04
2001941
to
ce3ead3
Compare
sjungling
force-pushed
the
refactor/uv
branch
from
December 19, 2024 21:06
ce3ead3
to
539a71a
Compare
natedanner
reviewed
Dec 20, 2024
natedanner
reviewed
Dec 20, 2024
supports iterating on existing set of logs
move model download up in the process to avoid possible cache layer invalidation
provides seam between two common actions of either downloading logs from Artifactory or running analysis. Analysis subcommand also provides means for either sourcing logs from a local directory instead of artifactory. In addition support for iterating on existing logs that have been process and are being manually marked as resolved
also utilize click's echo and prompting
probably not what we'd want
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Consolidate python methods and files to form a CLI to help offer easier discoverability of how to analyze either local logs or remote logs from Artifactory. Also switches to a smaller model for smaller, less memory/disk intensive, and faster results; results between two felt comparable. Rewrote direction for installation and running to support one of four different ways to configure: DevContainer, plain Docker, system Python, or with
uv
.Optimized various parts in part through the intermediate pickle files that were being written and read between steps.