Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WTR: browser exports are not resolved #2847

Open
tpluscode opened this issue Nov 28, 2024 · 0 comments
Open

WTR: browser exports are not resolved #2847

tpluscode opened this issue Nov 28, 2024 · 0 comments

Comments

@tpluscode
Copy link

For example, trying to import [email protected] will fail because the node export will be resolved. Here's excerpt from the package.json

{
  "name": "nanoid",
  "exports": {
    ".": {
      "browser": "./index.browser.js",
      "default": "./index.js"
    },
    "./non-secure": "./non-secure/index.js",
    "./package.json": "./package.json"
  },
  "browser": {
    "./index.js": "./index.browser.js"
  },
  "react-native": {
    "./index.js": "./index.browser.js"
  }
}

The fix appears to add browser to node resolve plugin

export default {
  nodeResolve: {
    exportConditions: ['browser', 'module', 'import', 'default'],
  }
}

I think this could be made the default when setting nodeResolve: true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant