Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal does not respect dark mode #172

Closed
VaZark opened this issue Aug 29, 2022 · 4 comments · Fixed by #176
Closed

Modal does not respect dark mode #172

VaZark opened this issue Aug 29, 2022 · 4 comments · Fixed by #176

Comments

@VaZark
Copy link

VaZark commented Aug 29, 2022

Describe the bug
When the search modal is opened in a browser that has dark mode by default. The theming support was added in django 3.2 (link)

To Reproduce
Steps to reproduce the behavior:

  1. Set browser to prefer dark mode
  2. Open the advanced filter modal on any page

Expected behavior
The modal should respect the CSS variables from django 3.2

Screenshots
image

Details (please complete the following information):

  • OS: linux
  • Python version : 3.9
  • Django version : 4.0
  • django-advanced-filters version : 2.0.0
  • Browser : Firefox
  • Version : 10
@VaZark
Copy link
Author

VaZark commented Aug 29, 2022

@asfaltboy
Copy link
Member

asfaltboy commented Oct 8, 2022

Thanks @VaZark , I switched to the var(--body-bg) in PR #176 . Could you give a try and let me know if it resolves your concern? My hope is it's a tiny bit simpler than the changes proposed in PR #173

@VaZark
Copy link
Author

VaZark commented Oct 10, 2022

Looks like the there one little field that has not been updated

image

@asfaltboy
Copy link
Member

Thanks for reminding me about it 🙇

Django has an autocomplete.css select2 theme (see here) that seems to do the job. We can play around with select2 themes in the draft PR #177 , as it switched to django vendored select2 v4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants