Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SimpleJSON optional #181

Open
baseplate-admin opened this issue Dec 6, 2022 · 1 comment · May be fixed by #182
Open

Make SimpleJSON optional #181

baseplate-admin opened this issue Dec 6, 2022 · 1 comment · May be fixed by #182

Comments

@baseplate-admin
Copy link

Is your feature request related to a problem? Please describe.
Hi there, It Seems that you guys bundle simplejson when installing the project. Is it possible not to do this? Because its yet another dependency when i have orjson, pysimdjson in my project.

Describe the solution you'd like
Make SimpleJson optional. Preferably with django-advanced-filters[simplejson]

Describe alternatives you've considered
Forking the project and making a downstream patch

Additional context
Now that CPython is getting faster chances are we wont need simplejson to make things faster unless i am missing something here

Thanks :D

@aqeelat
Copy link

aqeelat commented Dec 11, 2022

I agree here. I even think simplejson should be removed since the features we need are included in stdlib.

@baseplate-admin baseplate-admin linked a pull request Jan 24, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants