Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent page navigation from 5th page of search results #1572

Closed
obnyis opened this issue Jul 2, 2023 · 2 comments
Closed

Inconsistent page navigation from 5th page of search results #1572

obnyis opened this issue Jul 2, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request web Relates to Modrinth.com web frontend

Comments

@obnyis
Copy link

obnyis commented Jul 2, 2023

Is your suggested enhancement related to a problem? Please describe.

When navigating through multiple pages of search results, to go from the 5th page to the 6th you need to use the next page arrow.

This should switch to the 1 - 4 5 6 - X form to allow continued navigation by selection of a page number.

Describe the solution you'd like

Line 96 in ui/Pagination.vue should be updated to else if (this.page > 4) {

https://github.com/modrinth/knossos/blob/05d994889d8567240148047e5a0384c1819615ee/components/ui/Pagination.vue#L96C36-L96C36

Describe alternatives you've considered

No response

Additional context

When on the 5th page:
image

After navigating to the 6th page:
image

When on the 4th from last page:
image

After navigating to the 5th from last page:
image

@obnyis obnyis added the enhancement New feature or request label Jul 2, 2023
@triphora
Copy link
Contributor

triphora commented Jul 2, 2023

This was changed in modrinth/knossos#1181 - @Prospector something for you

@Prospector Prospector transferred this issue from modrinth/knossos Aug 3, 2024
@Prospector Prospector added the web Relates to Modrinth.com web frontend label Aug 3, 2024
@Minenash
Copy link
Contributor

Fixed at some point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request web Relates to Modrinth.com web frontend
Development

No branches or pull requests

4 participants