Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination of Version Pages is Broken #1615

Closed
douira opened this issue Apr 21, 2023 · 2 comments
Closed

Pagination of Version Pages is Broken #1615

douira opened this issue Apr 21, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@douira
Copy link

douira commented Apr 21, 2023

Describe the bug

Clicking on the page buttons at the bottom of a mod page with many pages of versions doesn't work correctly.

  1. It requires two clicks to open the actually correct page
  2. Passing a page parameter in the URL doesn't work
  3. Clicking on any page button if the current page is at least page 3 jumps back to page 1
  4. Clicking the next button goes back to page 1
  5. Clicking the back button goes back to page 1

Tested in latest Chrome 112 and Safari 16.3 on macOS.

Steps to reproduce

Step 0 of each problem: Go to a mod page with many versions like JEI https://modrinth.com/mod/jei/versions

For 1.

  1. Click the button for page 4
  2. Observe that nothing happens
  3. Click it again
  4. Page 4 opens

For 2.

  1. Open https://modrinth.com/mod/jei/versions?p=4
  2. It doesn't open page 4

For 3.

  1. Go to page 3 by clicking on it twice
  2. Click on page 4
  3. It goes back to page 1

For 4.

  1. Click the next button
  2. Nothing happens
  3. Sometimes it does switch to page 2, but then goes back to page 1

If done starting on page 3, it goes back to page 1.

For 5.

  1. Go to page 3 by clicking it twice
  2. Click the back button
  3. It goes back to page 1

Expected behavior

The pagination bar should behave as expected from a regular pagination bar:

  • Clicking the page goes to the right page
  • Passing an URL parameter should open the given page
  • Clicking the next or back button moves one page

Additional context

Screen recording of the various problems (heavily compressed to get within file size limit):

recording.mov
@falseresync
Copy link
Contributor

I confirm the issue on Firefox 112 / Windows 10

@triphora
Copy link
Contributor

Fixed in modrinth/knossos#1181

@Prospector Prospector transferred this issue from modrinth/knossos Aug 3, 2024
AarhamH pushed a commit to AarhamH/theseus that referenced this issue Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
3 participants