-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packaging solutions #497
Comments
For Linux these two Tauri issues are related: |
At least make a PKGBUILD that extracts the deb package to be used as an archlinux pacman package. |
Here is a PKGBUILD for archlinux that extracts a .deb package https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=linux-xanmod-linux-bin-x64v3 |
this isn't a good method for the long term, especially as arch is known to make abi incompatible changes to packages frequently, or at the very least push versions of libraries usually incompatible with those found on debian/ubuntu based distros (there are also problems between those, but usually less so). here's a good example for a temporary thing it would probable be fine? but ideally all community packages should be built against their distro's packages to ensure the final binaries actually work |
i 100% agree with this. it's very hard and completely impractical for upstream to support the endless amounts of linux distributions out there; universal solutions should be the main focus here, along with basic files for distribution that can be used there and in downstream packages the biggest issue here is that networking may need to be enabled during building due to flatpak's build tools lacking support for pnpm lock files. this is a problem since flathub doesn't really like that and it could make it very difficult for it to be uploaded there this is pretty much complete and fully working on any linux distro. macos support for is being worked on. the problem with pnpm and offline builds also showed up here, but since nix is a lot more flexible with it's build process, i was able to figure out a way to maintain reproducibility while still using pnpm's lock file. i will try to upstream this in nixpkgs once a stable release is made like you said, these should probably be community packages. i would like to note though that some may be difficult (mainly fedora rpms) due to the issue with pnpm and offline builds as mentioned before. arch is very lose with this though so it should work fine; i can't say anything about alpine since i've never used/packaged for it personally the only other thing i would like to note is that tauri's native package export feature really shouldn't be used here. the current debian package for example seems to strip out the other tools theseus provides such as it's cli, doesn't include dependency information (i'm assuming the direct dependencies of theseus are compiled statically...which isn't great but works ig) which can cause issues with even launching minecraft, and in general is very inflexible for the future where manual intervention for packaging may be required. i'm shocked the deb package works in it's current state, let alone if it can even actually start minecraft ootb. we should be following the standard of other linux packages (specifically packages for other launchers) by supporting the formats themselves instead of relying on a tool that in all honestly, doesn't produce good packages. most of this will fall on the community of individual distros, but for a download link on the upstream maintainer's website, poorly auto generated debs and appimages aren't really acceptable for "linux support" imo. the best solution to fix this is flatpak edit: macos support for nix is available now. discussion about upstreaming to nixpkgs will be in NixOS/nixpkgs#247468 (thanks PC!) |
Tauri issue and PR for Arch Linux: |
I'd be willing to draft |
If you do go for Flatpak, please, PLEASE include proper permissions. I'm tired of having to deal with broken permissions on Flatpak packages. |
Flatseal can help with fixing those, but agreed. |
The user shouldn't have to use Flatseal to fix broken permissions provided by the package, that's just bad design |
Again, I said I agreed |
There is a tool to generate flatpak builder sources definitions from Besides that, we probably will need to disable auto updating for the flatpak package. If there is no better way, that could be done with some Since the whole app is bundled in a single executable, packaging it as a flatpak would probably be pretty easy. |
Actually, on a closer look, the resulting binary has quite a few dynamic dependencies. I'll try to see if I can put all of them into the flatpak |
I just made a forum thread in the Modrinth Discord server |
3 days and still no mention of |
Ew, Snaps. |
quoting a message i made here: nix packaging for linux and darwin is basically complete, just needs a few little touchups. i have flatpak almost working, but as it stands it would only be able to be distributed through flathub - only the website. this is due to no flatpak build tools supporting pnpm’s lockfile format; it’s a similar case with nix, but there are a few diy methods already in nixpkgs i was able to use so not an issue there. for flatpak, networking needs to be enabled during the build but that’s a big nono only other “issue” is that tauri (or what i’m hoping to be only the specific version of tauri being used) is using an old version of webkitgtk to build so…i need to compile all of webkitgtk for it to work, which causes my pc to oom it seems that upstream is willing to switch to npm (source) which solves the first issues; everything else with the flatpak seems pretty good. one thing i thought of though was making some packaging guidelines for the app, as currently some things such as actual naming can be unclear. maybe this could be done with upstream sources for stuff like desktop files? |
You and the Modrinth team would probably be better at chatting about how this would work imo. I mostly broght up Flatpak due to it being more secure thanks to its sandboxed nature. And, Snaps also suck, Debs are kinda the stone-age of package formats, and AppImages are kinda annoying due to you having to manually download each new AppImage per update. Also, both the Deb and AppImage Modrinth provides seem to be quite buggy. At least, afaik. |
I was joking about snaps (unfortunately Canonical isn't), and I've had tonnes of issues with installing the DEB version at all, plus packaging systems that bundle everything like AppImages and Flatpak tend to take up more space than native (10x more for the modrinth app), which might be an issue for some people. |
Eh, true. But there's no real universal way of packaging apps easily. |
this is basically a made up number. in fact, most of modrinth app's dependencies are already in the runtime - this means unlike some flatpaks, there are very few dependencies specific to it that need to be bundled. it should be a similar size to the deb + the size of the runtime |
I was more talking about the appimage, I'm aware that flatpak has measures to keep its size down. |
I'll add that flatpak is what the Steam Deck is using, so that's a big gaming base there |
flatpak is supported by almost all modern distros in general, but the deck can run the AppImage. |
They have been actively working on it, but the work has stalled being blocked by Tauri dependencies. It seems that the work on Flatpak version will continue after Tauri 2.0 is released (after Q1 2024) |
The issue for tauri apps as RPM has been recently closed and compatibility has been added. Now modrinth can be packaged for Fedora. |
i've opened a PR for nixpkgs; flathub is next |
@intergrav, don't merely package RPMs for Fedora — make them compatible with openSUSE (and others) too, using universal RPM packaging, as https://forums.opensuse.org/t/proton-bridge-installation-error/172223/5 explains. I'd also build them at the OBS (as chidiwilliams/buzz#466 (comment) explains). |
this shouldn't be used. it will have the same issues as the current deb package, as tauri has no idea it's meant to also launch minecraft
this can get messy very fast. i've attempted it before with prismlauncher, and while it did work, it made the spec files more much difficult to maintain with little benefit. i would highly advise against anyone doing this, especially if you are also targeting leap releases as well as tumbleweed or fedora + enterprise linux.
this is a good idea though!...just not for fedora. copr is much better for fedora users with it's built in support, and likewise obs is great for suse users with it's built in support but not so great on fedora. in my experience, users of both distros also overwhelmingly prefer their "native" platforms |
for anyone who's missed it: the flathub pr is up! you can find the link in the original post for this thread |
Still has a bunch of unfixed stuff though |
it works fine outside of bugs found in webkitgtk (so nothing specific to the package). anything mentioned there is only about meeting flathub's guidelines rather than getting a working flatpak period |
Ah. |
@jptrzy you think I should just remove the mention of an Alpine package in this issue considering that it doesn't make sense to use it in it's current state? I'll remove it for now but lmk if you want me to add it back to the issue. |
I'm currently working on cleaning up and updating the issue with latest info |
Hi why isn't the Flathub package on the Modrinth website ? It still downloads the appimage by default and there isn't any kind of flatpak support outside of third party packages. Is the flatpak support is official or not, and if yes, why is it hidden in third party packages ? |
@intergrav This isn't true - I said I would be willing to work on one if required. |
@CompeyDev fixed :) |
it is not, which is why it's placed there |
I'm suggesting my improved version of @brawaru 's Scoop package manifest: https://github.com/Bobrokus/grain/blob/master/bucket%2Fmodrinth-app.json I might also ask for merging into the official |
This is highly concerning. You should not get rid of
This will have an unwanted side of effect of forcing every Modrinth App instance running on your Windows account to use the persist directory for Scoop installation of Modrinth App. |
Either way, thanks for the useful feedback, and let me know what you think! |
I have packaged modrinth-app in a Fedora Copr, available here: https://copr.fedorainfracloud.org/coprs/sid127/packages and am willing to continue to maintain it the .spec is adapted from the AUR PKGBUILD, but I run into an error where the app is unable to find
|
Hello, I have read the entire discussion, but I am still unsure why Flatpak is not officially supported. Is it due to a technical issue or a lack of resources? |
What about snaps? |
Snaps are not being dealt with by anyone as far as I know. |
Ew, Snaps. |
* Fix statuses again * Make it compile
At the time of writing, there are only two official ways for using the Modrinth App on Linux - AppImages and Debian packages. While this is fine for people on Debian-based distributions, and those who like using AppImages, some may prefer to use a package manager such as
flatpak
ordnf
as it's easier to manage packages that way. According to this comment, the current compiled Debian packages aren't very great right now because they don't include proper dependency info and leave out some important stuff.Along with AppImages and Debian packages, there are various packaging solutions to consider. If there's other packaging types that you think would be a good idea, suggest them in this thread. I personally think that the Flatpak should be maintained by Modrinth, and the rest could be maintained by members of the community if they wanted to do so. I think this is especially important as the Modrinth App is now in an open beta.
This issue serves as a place to discuss packaging, and I'll also treat this as a sort of "unofficial download page" for Linux users with updated information on what packages to use and where to get them.
Indicators
✅
🔃
Unix/Unix-like packaging
✅ Flatpak
Package is available and maintained on Flathub - thank you @getchoo and other contributors!
Package that can be used on most common Linux distributions, and also good for security as Flatpaks are sandboxed unlike other types. This will be the package that most Linux users are looking for.
Notable mentions/issues
Who's working on this?
✅ Arch
Packages are available and maintained on the AUR -
modrinth-app
andmodrinth-app-bin
- thank you Antti!Any ideas on this?
deb
package to be used as an Arch pacman package. Here's an exampleNotable mentions/issues
Who's working on this?
modrinth-app
modrinth-app-bin
modrinth-app-git
modrinth-cli-git
✅ Nix
Package is available and maintained on Nixpkgs -
modrinth-app
- thank you @getchoo and other contributors!Nix can be used on both Linux and Darwin systems and is the package manager for NixOS.
Who's working on this?
Fedora Copr
User-maintained package repositories for Fedora, CentOS Stream, and RHEL. Can be enabled with
dnf copr enable <author>/<repo>
Notable mentions/issues
Homebrew cask
Homebrew is a package manager for MacOS (and Linux). Idea from #560. It would allow for easy installation on MacOS.
Windows packaging
🔃 🍨 Scoop
Package is available and maintained on brawaru/bucket - thank you @brawaru!
Scoop is a command-line installer for Windows. It has many benefits, such as installing packages in a portable way (by default, it installs packages to
~/scoop
). Package manifests are just simple JSON files - this shouldn't be too hard to set up.✅ WinGet
Package is available and maintained on WinGet - thank you @TheBossMagnus and other contributors!
WinGet is Microsoft's own package manager.
Other information
Theseus is very complex to package and doing so for many different formats at a time would be a little chaotic. I think that the common package types like Flatpak, Arch and Nix packages should be done.
Leave your thoughts below!
For discussion, see the thread in the
#development
channel of the Modrinth Discord. You can also continue discussing here if you prefer that.The text was updated successfully, but these errors were encountered: