Skip to content

Issues: modular-network/ethereum-libraries-wallet

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23 Open 0 Closed
23 Open 0 Closed
Author
Filter by author
Loading
Label
Filter by label
Loading
Use alt + click/return to exclude labels
or ⇧ + click/return for logical OR
Projects
Filter by project
Loading
Milestones
Filter by milestone
Loading
Assignee
Filter by who’s assigned
Sort
Sort by
Newest Oldest Most commented Least commented Recently updated Least recently updated Best match
Most reactions
👍 👎 😄 🎉 😕 ❤️ 🚀 👀

Issues list

underscores needed in parameters
#24 opened Apr 25, 2018 by joshuahannan
required sigs checks in init
#23 opened Apr 25, 2018 by joshuahannan
calcconfirmsneeded repetitive
#22 opened Apr 25, 2018 by joshuahannan
correct return codes
#21 opened Apr 25, 2018 by joshuahannan
Inconsistent requirement for requiredMajor
#20 opened Apr 25, 2018 by joshuahannan
Duplicate owners can exist
#19 opened Apr 25, 2018 by joshuahannan
Admin validation functions are poorly encapsulated
#18 opened Apr 25, 2018 by joshuahannan
1
Confusing day limit mapping
#17 opened Apr 25, 2018 by joshuahannan
1
Redundant error logs
#16 opened Apr 25, 2018 by joshuahannan
1
Some members of the Transaction struct are never used
#15 opened Apr 25, 2018 by joshuahannan
getRequired should not be in charge of resetting currentSpend
#14 opened Apr 25, 2018 by joshuahannan
Potential overflow in day limit tracking
#13 opened Apr 25, 2018 by joshuahannan
1
Contract creation function has no confirmation checking
#12 opened Apr 25, 2018 by joshuahannan
Poor definition of function visibility
#11 opened Apr 25, 2018 by joshuahannan
Complex conditional paths
#10 opened Apr 25, 2018 by joshuahannan
1
Incorrect error checking of contract creation
#9 opened Apr 25, 2018 by joshuahannan
Handling of both ether and token transfers produce fragile code
#7 opened Apr 19, 2018 by joshuahannan
1
Day limits do not represent extraction limits but authorization limits
#6 opened Apr 19, 2018 by joshuahannan
1
Insufficient Coverage of Token Standards
#5 opened Apr 19, 2018 by joshuahannan
1
Code duplication
#4 opened Apr 18, 2018 by joshuahannan
All token transfers will require major confirmations if ETH threshold is reached
#3 opened Apr 18, 2018 by joshuahannan
1
Invalid confirmation sneaky transaction
#2 opened Apr 18, 2018 by joshuahannan
Major-minor switch-a-roo
#1 opened Apr 18, 2018 by joshuahannan
ProTip! What’s not been updated in a month: updated:<2024-11-11.