Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional signature file format not using Java Serialization #252

Open
Marcono1234 opened this issue Jul 5, 2023 · 0 comments
Open

Comments

@Marcono1234
Copy link
Contributor

Marcono1234 commented Jul 5, 2023

Currently Animal Sniffer uses Java Serialization (ObjectOutputStream) as format for the signature files:

oos = new ObjectOutputStream( new GZIPOutputStream( out ) );

This makes it rather inconvenient to use third-party signatures because Java Serialization can in the worst case lead to remote code execution, so you would have to trust the source of those signature files 100% when using them. And verifying that the serialization data in a signature file is safe and does not contain any malicious content is not easily possible.

Would it be possible to support an additional signature file format such as JSON which does not have these security issues (and allow specifying the signature type in the Maven plugin configuration)?
Then it would be easier to use third-party signature files, even if you don't fully trust the author. Because you can easily inspect the Maven artifact and verify that it only contains a JSON signature file. In the worst case that JSON file could crash your build if it is malformed or cause a denial of service attack for your build, but it cannot cause execution of arbitrary malicious code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants