You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
oos = newObjectOutputStream( newGZIPOutputStream( out ) );
This makes it rather inconvenient to use third-party signatures because Java Serialization can in the worst case lead to remote code execution, so you would have to trust the source of those signature files 100% when using them. And verifying that the serialization data in a signature file is safe and does not contain any malicious content is not easily possible.
Would it be possible to support an additional signature file format such as JSON which does not have these security issues (and allow specifying the signature type in the Maven plugin configuration)?
Then it would be easier to use third-party signature files, even if you don't fully trust the author. Because you can easily inspect the Maven artifact and verify that it only contains a JSON signature file. In the worst case that JSON file could crash your build if it is malformed or cause a denial of service attack for your build, but it cannot cause execution of arbitrary malicious code.
The text was updated successfully, but these errors were encountered:
Currently Animal Sniffer uses Java Serialization (
ObjectOutputStream
) as format for the signature files:animal-sniffer/animal-sniffer/src/main/java/org/codehaus/mojo/animal_sniffer/SignatureBuilder.java
Line 137 in e530b56
This makes it rather inconvenient to use third-party signatures because Java Serialization can in the worst case lead to remote code execution, so you would have to trust the source of those signature files 100% when using them. And verifying that the serialization data in a signature file is safe and does not contain any malicious content is not easily possible.
Would it be possible to support an additional signature file format such as JSON which does not have these security issues (and allow specifying the signature type in the Maven plugin configuration)?
Then it would be easier to use third-party signature files, even if you don't fully trust the author. Because you can easily inspect the Maven artifact and verify that it only contains a JSON signature file. In the worst case that JSON file could crash your build if it is malformed or cause a denial of service attack for your build, but it cannot cause execution of arbitrary malicious code.
The text was updated successfully, but these errors were encountered: