Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(directory): filtering in the directory landing page should keep on working with the new services data model #3770

Open
esthervanenckevort opened this issue May 22, 2024 · 3 comments · May be fixed by #4155
Open

feat(directory): filtering in the directory landing page should keep on working with the new services data model #3770

esthervanenckevort opened this issue May 22, 2024 · 3 comments · May be fixed by #4155
Labels
app:catalogue app:directory data-model priority Features/bugs that we should not let wait

Comments

@esthervanenckevort
Copy link
Member

esthervanenckevort commented May 22, 2024 •
edited by mswertz
Loading

Demo:

  • I can use the service filters using the new services data model (we expect to take new services data model in production when done)

Image

@esthervanenckevort please delete or edit below.

Is your feature request related to a problem? Please describe.
Services need to be a implemented with additional metadata describing the service offered. A single term from an ontology is not sufficient, we need space for things like a description, cost information, etc. This means the services will become a separate entity in the model and the services filter and display needs to be adjusted for that.

Describe the solution you'd like
Services filter should be adjusted to filter on the service type of the new entity that describes the service offered so that you can still filter on specific services.

Describe alternatives you've considered
We considered different models for the services. Described in this document:

https://docs.google.com/document/d/1C_43Qnd9Swx-7bSF2KD7exVUXVd6nlROLUYoNjKGDbw/edit?usp=share_link

Additional context
Work is lead by CS-IT WP4, especially Andrzej Strug
@esthervanenckevort esthervanenckevort added the priority Features/bugs that we should not let wait label Jul 19, 2024
@mswertz
Copy link
Member

mswertz commented Jul 23, 2024

I suppose this one needs to be shortlisted. Why did you make this a 'dev' instead of 'catalogue' topic?

In any case I would like this one discussed in broader group so we properly understand goals and approach.

@esthervanenckevort
Copy link
Member Author

There are two related stories, one for each team. There is a data management and a code part

@mswertz mswertz changed the title Directory: refactor services feat(directory): refactor services Jul 26, 2024
@dtroelofsprins dtroelofsprins linked a pull request Aug 22, 2024 that will close this issue
Open
4 tasks
@dtroelofsprins dtroelofsprins linked a pull request Aug 22, 2024 that will close this issue
feat(directory): biobank services as a separate entity #4155
Open
4 tasks
@dtroelofsprins
Copy link
Contributor

DM part has finished (needs review from Esther), so this story is no longer blocked.

@mswertz mswertz changed the title feat(directory): refactor services feat(directory): filtering in the directory landing page should keep on working with the new services data model Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app:catalogue app:directory data-model priority Features/bugs that we should not let wait
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(directory): biobank services as a separate entity molgenis/molgenis-emx2
3 participants
@mswertz @esthervanenckevort @dtroelofsprins