From a54df07ebbfaedc259ff5d92751769a116b67131 Mon Sep 17 00:00:00 2001
From: mswertz <m.a.swertz@rug.nl>
Date: Sun, 13 Oct 2024 13:05:25 +0200
Subject: [PATCH 1/2] fix(catalogue): resource details page not rendering when
 resource.peopleInvolved is empty

---
 .../[catalogue]/[resourceType]/[resource]/index.vue             | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/apps/nuxt3-ssr/pages/[schema]/ssr-catalogue/[catalogue]/[resourceType]/[resource]/index.vue b/apps/nuxt3-ssr/pages/[schema]/ssr-catalogue/[catalogue]/[resourceType]/[resource]/index.vue
index 0147bfdaa7..9374c0e54e 100644
--- a/apps/nuxt3-ssr/pages/[schema]/ssr-catalogue/[catalogue]/[resourceType]/[resource]/index.vue
+++ b/apps/nuxt3-ssr/pages/[schema]/ssr-catalogue/[catalogue]/[resourceType]/[resource]/index.vue
@@ -506,7 +506,7 @@ if (route.params.catalogue) {
 }
 
 const contributors = computed(() =>
-  resource.value.peopleInvolved.sort((a, b) => {
+  resource.value.peopleInvolved?.sort((a, b) => {
     const minimumOrderOfRolesA = a.role?.length
       ? Math.min(...a.role?.map((role) => role.order ?? Infinity))
       : Infinity;

From 6c74412502250ccafacdb5aa671c879acc4885a2 Mon Sep 17 00:00:00 2001
From: mswertz <m.a.swertz@rug.nl>
Date: Mon, 14 Oct 2024 16:31:29 +0200
Subject: [PATCH 2/2] rename computed field to be more meaningful

---
 .../[catalogue]/[resourceType]/[resource]/index.vue       | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/apps/nuxt3-ssr/pages/[schema]/ssr-catalogue/[catalogue]/[resourceType]/[resource]/index.vue b/apps/nuxt3-ssr/pages/[schema]/ssr-catalogue/[catalogue]/[resourceType]/[resource]/index.vue
index 9374c0e54e..56c0529048 100644
--- a/apps/nuxt3-ssr/pages/[schema]/ssr-catalogue/[catalogue]/[resourceType]/[resource]/index.vue
+++ b/apps/nuxt3-ssr/pages/[schema]/ssr-catalogue/[catalogue]/[resourceType]/[resource]/index.vue
@@ -284,7 +284,7 @@ const tocItems = computed(() => {
       id: "Organisations",
     });
   }
-  if (contributors.value) {
+  if (peopleInvolvedSortedByRoleAndName.value) {
     tableOffContents.push({
       label: "Contributors",
       id: "Contributors",
@@ -505,7 +505,7 @@ if (route.params.catalogue) {
     ] = `/${route.params.schema}/ssr-catalogue/all/${resourceType.path}`;
 }
 
-const contributors = computed(() =>
+const peopleInvolvedSortedByRoleAndName = computed(() =>
   resource.value.peopleInvolved?.sort((a, b) => {
     const minimumOrderOfRolesA = a.role?.length
       ? Math.min(...a.role?.map((role) => role.order ?? Infinity))
@@ -596,10 +596,10 @@ const showPopulation = computed(
         ></ContentBlockOrganisations>
 
         <ContentBlockContact
-          v-if="contributors"
+          v-if="peopleInvolvedSortedByRoleAndName"
           id="Contributors"
           title="Contributors"
-          :contributors="contributors"
+          :contributors="peopleInvolvedSortedByRoleAndName"
         >
         </ContentBlockContact>