From 2efe75fe47c2a6bd607a2f13a38eacac25918a1f Mon Sep 17 00:00:00 2001 From: Neil MacDougall Date: Wed, 12 Jun 2024 19:13:28 +0100 Subject: [PATCH] Fix typo in EKS versions and add unit test (#11217) * Fix typo in EKS versions and add unit test * Fix lint --- .../assets/data/__tests__/eks-versions.tests.ts | 16 ++++++++++++++++ pkg/eks/assets/data/eks-versions.js | 2 +- 2 files changed, 17 insertions(+), 1 deletion(-) create mode 100644 pkg/eks/assets/data/__tests__/eks-versions.tests.ts diff --git a/pkg/eks/assets/data/__tests__/eks-versions.tests.ts b/pkg/eks/assets/data/__tests__/eks-versions.tests.ts new file mode 100644 index 00000000000..7c5f96b4e30 --- /dev/null +++ b/pkg/eks/assets/data/__tests__/eks-versions.tests.ts @@ -0,0 +1,16 @@ +import eksVersions from '../eks-versions'; + +const EKS_VERSION_REGEX = /^[0-9]+\.[0-9]+$/; + +describe('eks versions', () => { + it('should be valid version numbers', () => { + eksVersions.forEach((version) => { + const m = version.match(EKS_VERSION_REGEX); + + expect(m).toBeDefined(); + expect(m).not.toBeNull(); + expect(m?.length).toBe(1); + expect(m?.[0]).toBe(version); + }); + }); +}); diff --git a/pkg/eks/assets/data/eks-versions.js b/pkg/eks/assets/data/eks-versions.js index 8642b3054ae..fdd2a6e15f4 100644 --- a/pkg/eks/assets/data/eks-versions.js +++ b/pkg/eks/assets/data/eks-versions.js @@ -1,4 +1,4 @@ -export default ['[1.29', +export default ['1.29', '1.28',