Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide make goal for upheno2-merged.owl #8

Closed
matentzn opened this issue Aug 16, 2023 · 2 comments · Fixed by #11
Closed

Provide make goal for upheno2-merged.owl #8

matentzn opened this issue Aug 16, 2023 · 2 comments · Fixed by #11
Assignees

Comments

@matentzn
Copy link
Member

This is the replacement ticket for obophenotype/upheno-dev#38

We need to iterate over this goal, as it is, as of yet, not clear how to fix this. In the old uPheno,

MP:123 = HP:123.

In uPheno2, MP:123 sub UPHENO:111, HP:123 sub UPHENO:111, so the equivalence axiom is replaced by a common parent. This drastically changes the way (graph-based) semantic similarity algorithms behave.

This is the key ticket: INCATools/ontology-access-kit#634

@souzadevinicius This has a high priority, but right now, I don't know how to advice you on fixing it.

Can you make sure this does not fall under the radar, and mention it to me every time we meet? (add to your board as high priority)

@matentzn
Copy link
Member Author

I think we have a solution now:

  1. change mapping predicate to owl:equivalentClass
  2. Run semsql afterwards as relationgraph will deal with the issue

Interesting: in the issue INCATools/ontology-access-kit#634 explains an hypothesis that actually children of equivalent classes will move closer together in the semantic space, which may introduce a bias. Ask me about this @souzadevinicius if you want to understand better :)

@matentzn
Copy link
Member Author

Did this work? Do you see significant differences in the upheno2-lattice and upheno2-equivalence profiles?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants