Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage badges #4

Open
oneilsh opened this issue Jun 15, 2023 · 6 comments
Open

Add code coverage badges #4

oneilsh opened this issue Jun 15, 2023 · 6 comments
Assignees
Labels
chore Metadata, non-user functionality & docs

Comments

@oneilsh
Copy link
Collaborator

oneilsh commented Jun 15, 2023

No description provided.

@bschilder
Copy link
Contributor

Since you're already using rworkflows, you could also use rworkflows::use_badges in your README, which collects and render all the badges for you.

I'll make a PR for this

@bschilder
Copy link
Contributor

added here: #15

@oneilsh
Copy link
Collaborator Author

oneilsh commented Jul 26, 2024

Thanks Brian - just making a note for this one that I have yet to link them to codecov.io

@oneilsh oneilsh added the chore Metadata, non-user functionality & docs label Jul 26, 2024
@oneilsh
Copy link
Collaborator Author

oneilsh commented Aug 16, 2024

Hmm, so I could use some help getting the rworkflows checks and badges running properly. @bschilder, would you mind taking a look? I had previously removed Windows and OSX builds in rworkflows.yml as they were breaking (but not sure why), and I turned off run_rcmdcheck but I think it's ready to go now. I should be able to setup the link to codecov.io, but I don't remember how to trigger the codecov.yaml generation. And, I'm not sure if README.md is being properly built from README.Rmd.

Basically, I broke a lot of the rworkflows stuff to get the GH pages site to properly publish...

@bschilder
Copy link
Contributor

bschilder commented Aug 19, 2024

The codecov.yaml should't be necessary anymore. Once rworkflows passes all the previous steps the codecov report should automatically be uploaded to Codecov and the badge will be updated.

That said, this only happens automatically when Codecov isn't having problems. We just added a new feature to rworkflows that allows you to supply the CODECOV token (which can be stored in the monarchr repo as a GitHub secret), just in case we need it.

neurogenomics/rworkflows#132

@bschilder
Copy link
Contributor

The reason the Codecov badge isn't updating here could be due to a permissions issue with the monarchr repo, or the monarch-initiative org in general (I see none of the repos have been activated for codecov).
https://app.codecov.io/gh/monarch-initiative

Someone with admin permissions might need to follow some of these steps to let Codecov do its thing:
https://docs.codecov.com/docs/quick-start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Metadata, non-user functionality & docs
Projects
None yet
Development

No branches or pull requests

2 participants