Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(chore) Move Helm & OLM integration tests before the publish step #420

Open
czunker opened this issue Jul 4, 2022 · 2 comments
Open

(chore) Move Helm & OLM integration tests before the publish step #420

czunker opened this issue Jul 4, 2022 · 2 comments
Labels
testing

Comments

@czunker
Copy link
Contributor

czunker commented Jul 4, 2022

What is not working as you expected it?
Helm & OLM tests are only run, when we publish.
In case something fails, we do partial publishs.

Where on the platform does it happen?
GitHub pipeline
OLM: https://github.com/mondoohq/mondoo-operator/blob/main/.github/workflows/publish.yaml#L268
Helm: https://github.com/mondoohq/mondoo-operator/blob/main/.github/workflows/publish.yaml#L364

How do we replicate the issue?

  • Force an error for the Helm release.
  • Tag new version
  • Release new verison

Expected behavior (i.e. solution)
Nothing should be released

Other Comments
For the OLM test, we need an image. This might be tricky.
@czunker czunker added the testing label Jul 5, 2022
@czunker
Copy link
Contributor Author

czunker commented Jul 6, 2022

For the OLM tests, v0.0.0-prerelease might work.

@czunker
Copy link
Contributor Author

czunker commented Jul 12, 2022

Also, try to use make targets where possible to get rid of duplicate code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@czunker