Skip to content
This repository has been archived by the owner on Mar 9, 2024. It is now read-only.

Multisignature support #45

Open
johndoe123445 opened this issue Mar 7, 2019 · 12 comments
Open

Multisignature support #45

johndoe123445 opened this issue Mar 7, 2019 · 12 comments

Comments

@johndoe123445
Copy link

Hello,

Thanks for the great work you’ve done there.

As you may know, monero v0.13.0.4 has finally stabilized M-N multisig of monero.

The JSON RPC has create_wallet, prepare_multisig, make_multisig, finalize_multisig to create a multisignature wallet.

Can you implement that feature to this wonderful library? I would like to help, but the creation is too complicated for the api to expose the methods clean.

Thanks.

@emesik
Copy link
Contributor

emesik commented Mar 8, 2019

Definitely, multisig has been a part of the plan from the very beginning. As you see, the task is not trivial though. At the moment I can't give any time estimate when it could be done.

MMS also looks to be interesting feature to have implemented, as an add-on: https://rbrunner7.github.io/mms_full_manual

@johndoe123445
Copy link
Author

How about just a just simple wrapper for these?

create_wallet
prepare_multisig
make_multisig
finalize_multisig

@emesik
Copy link
Contributor

emesik commented Mar 13, 2019

Not so easy. The Wallet class is designed to run a single wallet only. We would need a WalletManager or some other higher-level handler for create_wallet. You may look for something similar in this project. Be aware, however, that code is highly experimental and crashes/hangs on IPC quirks very often.

Also, signing of transactions must be implemented, and we should distinguish signed and unsigned txs. I touched the topic in unsigned-tx branch but had no more time to work on it.

Certainly, it is an important feature but we need it to be designed well. If you, or anyone else, find the code in monerowalletpool useful here, I'm willing to release necessary parts under BSD license too.

@ghost
Copy link

ghost commented Jun 12, 2020

What's the development status of the multisig feature?

@emesik
Copy link
Contributor

emesik commented Jun 13, 2020

Not progressing. I'd love to have time to spend on it.

@h0ay
Copy link

h0ay commented Mar 13, 2022

is there any progress on monero multi sig support ?

@emesik
Copy link
Contributor

emesik commented Mar 14, 2022

None. I'm going to release 1.0 soon as there are no outstanding bug reports. Then I'll focus on new features but recently I don't have much time to spend on it.

@h0ay
Copy link

h0ay commented Mar 16, 2022

Lemme know if i can help you in anyway ,donations ,contributions

@emesik
Copy link
Contributor

emesik commented Mar 16, 2022

Actually I'm thinking about applying for funding. However, first I need to carve out time to read docs and estimate the effort.

@h0ay
Copy link

h0ay commented Mar 17, 2022

That's cool
Message me when you need the hep

@h0ay
Copy link

h0ay commented Mar 31, 2022

any discord or instant messaging contact ?
I could help you to get it started

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants