Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUST-1805 Only use js-sys with unknown os #442

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

abr-egn
Copy link
Contributor

@abr-egn abr-egn commented Nov 29, 2023

Fixes #441.

@abr-egn abr-egn marked this pull request as ready for review November 29, 2023 18:01
@abr-egn abr-egn merged commit 412e456 into mongodb:main Nov 30, 2023
@tyranron
Copy link
Contributor

tyranron commented Dec 12, 2023

This broke the 2.8.0 release on wasm32-wasi targets:

 error[E0433]: failed to resolve: use of undeclared type `SystemTime`
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bson-2.8.0/src/oid.rs:245:30
    |
245 |         let timestamp: u32 = SystemTime::now()
    |                              ^^^^^^^^^^ use of undeclared type `SystemTime`
    |
help: consider importing this struct
    |
4   + use std::time::SystemTime;
    |

error[E0433]: failed to resolve: use of undeclared type `SystemTime`
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bson-2.8.0/src/oid.rs:246:29
    |
246 |             .duration_since(SystemTime::UNIX_EPOCH)
    |                             ^^^^^^^^^^ use of undeclared type `SystemTime`
    |
help: consider importing this struct
    |
4   + use std::time::SystemTime;

To reproduce, just run cargo check -p bson --target wasm32-wasi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

js-sys should not be used when targeting wasm32-wasi
3 participants