From 47330523fd341a4840a9664f976687de9850b3e8 Mon Sep 17 00:00:00 2001 From: Stephen Lee Date: Fri, 11 Oct 2024 08:42:17 -0700 Subject: [PATCH] Fix tests --- packages/combobox/src/Combobox/Combobox.spec.tsx | 2 +- packages/menu/src/Menu.spec.tsx | 3 +++ packages/split-button/src/SplitButton/SplitButton.spec.tsx | 3 +++ 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/combobox/src/Combobox/Combobox.spec.tsx b/packages/combobox/src/Combobox/Combobox.spec.tsx index a5c6302935..96f6289fb2 100644 --- a/packages/combobox/src/Combobox/Combobox.spec.tsx +++ b/packages/combobox/src/Combobox/Combobox.spec.tsx @@ -823,7 +823,7 @@ describe('packages/combobox', () => { if (select === 'multiple') { expect(queryAllChips()).toHaveLength(0); } else { - expect(inputEl).toHaveValue(''); + await waitFor(() => expect(inputEl).toHaveValue('')); } }); }); diff --git a/packages/menu/src/Menu.spec.tsx b/packages/menu/src/Menu.spec.tsx index c8e9a74c95..b5543d6d4a 100644 --- a/packages/menu/src/Menu.spec.tsx +++ b/packages/menu/src/Menu.spec.tsx @@ -338,14 +338,17 @@ describe('packages/menu', () => { test('highlights the previous option in the menu', async () => { const { openMenu } = renderMenu({}); const { menuItemElements } = await openMenu(); + await waitFor(() => expect(menuItemElements[0]).toHaveFocus()); userEvent.keyboard('{arrowdown}'); userEvent.keyboard('{arrowup}'); expect(menuItemElements[0]).toHaveFocus(); }); + test('cycles highlight to the bottom', async () => { const { openMenu } = renderMenu({}); const { menuItemElements } = await openMenu(); + await waitFor(() => expect(menuItemElements[0]).toHaveFocus()); const lastOption = menuItemElements[menuItemElements.length - 1]; userEvent.keyboard('{arrowup}'); diff --git a/packages/split-button/src/SplitButton/SplitButton.spec.tsx b/packages/split-button/src/SplitButton/SplitButton.spec.tsx index 4849ac546c..eb799875fa 100644 --- a/packages/split-button/src/SplitButton/SplitButton.spec.tsx +++ b/packages/split-button/src/SplitButton/SplitButton.spec.tsx @@ -351,14 +351,17 @@ describe('packages/split-button', () => { test('highlights the previous option in the menu', async () => { const { openMenu } = renderSplitButton({ menuItems }); const { menuEl, menuItemElements } = await openMenu(); + await waitFor(() => expect(menuItemElements[0]).toHaveFocus()); userEvent.type(menuEl!, '{arrowdown}'); userEvent.type(menuEl!, '{arrowup}'); expect(menuItemElements[0]).toHaveFocus(); }); + test('cycles highlight to the bottom', async () => { const { openMenu } = renderSplitButton({ menuItems }); const { menuEl, menuItemElements } = await openMenu(); + await waitFor(() => expect(menuItemElements[0]).toHaveFocus()); const lastOption = menuItemElements[menuItemElements.length - 1]; userEvent.type(menuEl!, '{arrowup}');