From 56b58ec45c6dead503d8bc372221a242e87873f3 Mon Sep 17 00:00:00 2001 From: Stephen Lee Date: Tue, 9 Apr 2024 18:30:50 -0700 Subject: [PATCH 1/7] Update placeholder text color --- packages/select/src/MenuButton/MenuButton.styles.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/select/src/MenuButton/MenuButton.styles.ts b/packages/select/src/MenuButton/MenuButton.styles.ts index 6643768b17..cb52cf0b21 100644 --- a/packages/select/src/MenuButton/MenuButton.styles.ts +++ b/packages/select/src/MenuButton/MenuButton.styles.ts @@ -103,10 +103,10 @@ export const menuButtonFocusStyle: Record = { export const menuButtonDeselectedStyles: Record = { [Theme.Light]: css` - color: ${palette.gray.dark1}; + color: ${palette.gray.base}; `, [Theme.Dark]: css` - color: ${palette.gray.light1}; + color: ${palette.gray.dark1}; &:hover, &:active, From e5a5295fd18931580119cb1a258df03a82d6034a Mon Sep 17 00:00:00 2001 From: Stephen Lee Date: Tue, 9 Apr 2024 18:35:04 -0700 Subject: [PATCH 2/7] Update spacing --- packages/select/src/MenuButton/MenuButton.styles.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/select/src/MenuButton/MenuButton.styles.ts b/packages/select/src/MenuButton/MenuButton.styles.ts index cb52cf0b21..cd7f14dfcf 100644 --- a/packages/select/src/MenuButton/MenuButton.styles.ts +++ b/packages/select/src/MenuButton/MenuButton.styles.ts @@ -30,17 +30,17 @@ export const menuButtonStyleOverrides = css` export const menuButtonSizeStyle: Record = { [Size.Default]: css` > *:last-child { - padding: 0 12px; + padding: 0 ${spacing[300]}px; } `, [Size.Large]: css` > *:last-child { - padding: 0 12px 0 ${spacing[3]}px; + padding: 0 ${spacing[300]}px; } `, [Size.Small]: css` > *:last-child { - padding: 0 ${spacing[2]}px 0 10px; + padding: 0 ${spacing[200]}px; } `, [Size.XSmall]: css` @@ -48,7 +48,7 @@ export const menuButtonSizeStyle: Record = { font-size: ${typeScales.body1.fontSize}px; line-height: ${typeScales.body1.lineHeight}px; > *:last-child { - padding: 0 ${spacing[1]}px 0 10px; + padding: 0 ${spacing[200]}px; } `, }; From 0c05c2efebf458b15ea0c315a67c9743df8c892d Mon Sep 17 00:00:00 2001 From: Stephen Lee Date: Tue, 9 Apr 2024 18:44:23 -0700 Subject: [PATCH 3/7] Remove error icon from inside MenuButton --- .../src/MenuButton/MenuButton.styles.ts | 2 +- packages/select/src/MenuButton/MenuButton.tsx | 20 ++----------------- .../select/src/MenuButton/MenuButton.types.ts | 1 - packages/select/src/Select/Select.tsx | 1 - 4 files changed, 3 insertions(+), 21 deletions(-) diff --git a/packages/select/src/MenuButton/MenuButton.styles.ts b/packages/select/src/MenuButton/MenuButton.styles.ts index cd7f14dfcf..abb9092e5e 100644 --- a/packages/select/src/MenuButton/MenuButton.styles.ts +++ b/packages/select/src/MenuButton/MenuButton.styles.ts @@ -165,7 +165,7 @@ export const menuButtonTextWrapperStyle = css` justify-content: space-between; align-items: center; flex-grow: 1; - gap: ${spacing[1]}px; + gap: ${spacing[100]}px; overflow: hidden; `; diff --git a/packages/select/src/MenuButton/MenuButton.tsx b/packages/select/src/MenuButton/MenuButton.tsx index 1c1df9e5f1..3de0006f7a 100644 --- a/packages/select/src/MenuButton/MenuButton.tsx +++ b/packages/select/src/MenuButton/MenuButton.tsx @@ -3,18 +3,16 @@ import React, { useCallback, useContext } from 'react'; import Button, { Size as ButtonSize, Variant } from '@leafygreen-ui/button'; import { css, cx } from '@leafygreen-ui/emotion'; import CaretDownIcon from '@leafygreen-ui/icon/dist/CaretDown'; -import WarningIcon from '@leafygreen-ui/icon/dist/Warning'; import { useDarkMode } from '@leafygreen-ui/leafygreen-provider'; import { Theme } from '@leafygreen-ui/lib'; import { LGIDS_SELECT } from '../constants'; import { State } from '../Select/Select.types'; import SelectContext from '../SelectContext'; -import { mobileSizeSet, sizeSets } from '../styleSets'; +import { mobileSizeSet } from '../styleSets'; import { MobileMediaQuery, useForwardedRef } from '../utils'; import { - errorColor, menuButtonDeselectedStyles, menuButtonDisabledThemeStyles, menuButtonErrorStyle, @@ -42,7 +40,6 @@ const MenuButton = React.forwardRef( readOnly, onClose, onOpen, - errorMessage, state, baseFontSize, __INTERNAL__menuButtonSlot__, @@ -56,8 +53,6 @@ const MenuButton = React.forwardRef( const ref = useForwardedRef(forwardedRef, null); - const sizeSet = sizeSets[size]; - const onClick = useCallback(() => { if (open) { onClose(); @@ -81,8 +76,7 @@ const MenuButton = React.forwardRef( { [menuButtonDeselectedStyles[theme]]: deselected, [menuButtonDisabledThemeStyles[theme]]: disabled, - [menuButtonErrorStyle[theme]]: - state === State.Error && !!errorMessage, + [menuButtonErrorStyle[theme]]: state === State.Error, [css` letter-spacing: initial; `]: size === ButtonSize.XSmall, @@ -130,16 +124,6 @@ const MenuButton = React.forwardRef( > {text} - {state === State.Error && errorMessage && ( - - )} {children} diff --git a/packages/select/src/MenuButton/MenuButton.types.ts b/packages/select/src/MenuButton/MenuButton.types.ts index ba6ff29454..422537b54e 100644 --- a/packages/select/src/MenuButton/MenuButton.types.ts +++ b/packages/select/src/MenuButton/MenuButton.types.ts @@ -13,7 +13,6 @@ export interface MenuButtonBaseProps readOnly?: boolean; onClose: () => void; onOpen: () => void; - errorMessage?: string; state?: State; baseFontSize?: BaseFontSize; __INTERNAL__menuButtonSlot__?: React.ForwardRefExoticComponent< diff --git a/packages/select/src/Select/Select.tsx b/packages/select/src/Select/Select.tsx index 19d7d8ca09..867a367225 100644 --- a/packages/select/src/Select/Select.tsx +++ b/packages/select/src/Select/Select.tsx @@ -592,7 +592,6 @@ export const Select = forwardRef( aria-describedby={descriptionId} aria-invalid={state === State.Error} aria-disabled={disabled} - errorMessage={errorMessage} state={state} baseFontSize={baseFontSize} __INTERNAL__menuButtonSlot__={__INTERNAL__menuButtonSlot__} From 7e7d713352b83276fed95313e79fcfa1a8820c70 Mon Sep 17 00:00:00 2001 From: Stephen Lee Date: Tue, 9 Apr 2024 19:18:13 -0700 Subject: [PATCH 4/7] Add error icon and default error message below select --- packages/select/README.md | 2 +- packages/select/src/Select/Select.spec.tsx | 8 --- packages/select/src/Select/Select.styles.ts | 19 +++++++- packages/select/src/Select/Select.tsx | 54 ++++++++++++--------- 4 files changed, 50 insertions(+), 33 deletions(-) diff --git a/packages/select/README.md b/packages/select/README.md index 97354ac7c3..0c1f582bc2 100644 --- a/packages/select/README.md +++ b/packages/select/README.md @@ -69,7 +69,7 @@ import { Option, OptionGroup, Select, Size } from '@leafygreen-ui/select'; | `portalClassName` | `string` | Passes the given className to the popover's portal container if the default portal container is being used. | | | `popoverZIndex` | `number` | Sets the z-index CSS property for the popover. | | | `state` | `'none'`, `'error'` | Determines the state of the `` | `'none'` | -| `errorMessage` | `string` | Text that shows when the `state` is set to `error`. | `'This input needs your attention'` | -| `baseFontSize` | `'13'`, `'16'` | Determines the base font size if sizeVariant is set to `default` | `'13'` | -| `dropdownWidthBasis` | `'option'` \| `'trigger'` | Determines the width of the dropdown. `trigger` will make the dropdown width the width of the menu trigger. `option` will make the dropdown width as wide as the widest option. | `trigger` | +| `aria-label` | `string` | Must be provided if and only if neither `label` nor `aria-labelledby` is not provided. | | +| `description` | `React.ReactNode` | Text that gives more detail about the requirements for the input. | | +| `placeholder` | `string` | The placeholder text shown in the input element when an option is not selected. | `'Select'` | +| `disabled` | `boolean` | Disables the component from being edited. | `false` | +| `value` | `string` | Sets the `