[LG-5575] refactor(chat): remove spacious variant, remove div from LeafyGreenChatProvider, and remove peer dep if unnecessary #3294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c34830b The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Size Change: -23.3 kB (-1.29%) Total Size: 1.79 MB
ℹ️ View Unchanged
|
stephl3
force-pushed
the
steph/chat-rm-spacious
branch
from
7110790 to
2c729f9
Compare
stephl3
force-pushed
the
steph/chat-rm-spacious
branch
from
b5007d8 to
d31112a
Compare
stephl3
requested review from
TheSonOfThomp,
adamrasheed,
Copilot and
shaneeza
and removed request for
a team and
adamrasheed
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated "spacious" variant from the LeafyGreen Chat system, simplifying all chat components to use a single, consistent design. The changes eliminate variant-specific conditional logic throughout the codebase and remove the @lg-chat/leafygreen-chat-provider peer dependency from components that no longer need it.
Key changes:
- Removed
Variantenum andvariantprop fromLeafyGreenChatProvider - Eliminated spacious variant-specific props across all chat components (
align,avatar,baseFontSize,iconSlot,onClose, etc.) - Removed deprecated style exports and several component exports (e.g.,
MessageContainer,PopoverMessageFeedback,RadioButton)
Reviewed Changes
Copilot reviewed 123 out of 147 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
chat/leafygreen-chat-provider/src/LeafyGreenChatProvider/LeafyGreenChatProvider.tsx |
Removed ResizeObserver, containerWidth tracking, and variant prop; simplified provider to only manage assistantName |
chat/message/src/Message/Message.tsx |
Consolidated CompactMessage and SpaciousMessage into single Message component implementation |
chat/title-bar/src/TitleBar/TitleBar.tsx |
Removed Avatar, IconButton, and variant-specific rendering logic |
chat/input-bar/src/InputBar/InputBar.tsx |
Removed badge, gradient animation, hotkey indicator, and variant-specific button rendering |
chat/message-rating/src/MessageRating/MessageRating.tsx |
Removed RadioButton variant and description prop |
chat/message-feedback/src/InlineMessageFeedback/InlineMessageFeedback.tsx |
Removed cancel button and variant-specific layout logic |
chat/message-feed/src/MessageFeed/MessageFeed.tsx |
Consolidated CompactMessageFeed and SpaciousMessageFeed into single implementation |
chat/input-bar/package.json |
Updated react-textarea-autosize dependency from ^8.3.2 to ^8.5.9 |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
stephl3
changed the title
stephl3
force-pushed
the
steph/chat-rm-spacious
branch
from
36f3423 to
0c56610
Compare
…atProvider, and remove peer dep if unnecessary
stephl3
force-pushed
the
steph/chat-rm-spacious
branch
from
0c56610 to
c34830b
Compare
stephl3
commented
Nov 10, 2025
Collaborator
Author
stephl3
left a comment
stephl3
left a comment
There was a problem hiding this comment.
UI Tests have changed slightly now that I've decoupled most chat components from the LeafyGreenChatProvider. This also had a wrapper <div> element included in the provider, but now that it has been removed from stories, the snapshots should appear centered in most cases
stephl3
commented
Nov 10, 2025
Comment on lines
+49
to
+51
| export const interceptStyles = css` | ||
| min-height: 1px; | ||
| `; |
Collaborator
Author
There was a problem hiding this comment.
Most changes are removal of code. This is one spot I added something.
MessageFeed has 2 empty spans, aka intercepts. Their visibility is checked to determine if overflow shadows should be rendered. In certain containers, like a drawer UI, the browser was not considering the bottom intercept, so I added this min-height of 1px to ensure it was considered
Contributor
|
Coverage after merging steph/chat-rm-spacious into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
shaneeza
reviewed
Nov 11, 2025
shaneeza
reviewed
Nov 11, 2025
Collaborator
shaneeza
left a comment
shaneeza
left a comment
There was a problem hiding this comment.
I forgot to leave a comment, but everything looks good! I just had a few questions, and I left a few comments in Chromatic.
shaneeza
approved these changes
Nov 11, 2025
| "@leafygreen-ui/drawer": "workspace:^", | ||
| "@lg-chat/avatar": "workspace:^", | ||
| "@lg-chat/input-bar": "workspace:^", | ||
| "@lg-chat/leafygreen-chat-provider": "workspace:^", |
Collaborator
There was a problem hiding this comment.
I don't think this is correct. I think it should remain a peer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
This PR removes the spacious variant system from the chat components, which was previously deprecated in favor of the compact variant. The changes include:
Variantenum and all variant-related logic fromLeafyGreenChatProviderlgMessageFeedStyles,lgInputBarStyles,lgMessageStyles, etc.)PopoverMessageFeedback,RadioButton,MessageContainer, andCompactMessageFeeddescriptionfromMessageRating,isCompactandshouldRenderButtonTextfromInputBarSendButton, andbaseFontSizefromMessageContentonCloseandiconSlotprops fromChatWindowandTitleBarThis is a breaking change that simplifies the chat component API by removing the deprecated spacious variant and consolidating on a single, consistent compact design.
🎟️ Jira ticket: LG-5575
✅ Checklist
pnpm changesetand documented my changes🧪 How to test changes
variantprop onLeafyGreenChatProvider