code review changes.

Author: craiggwilson

CSharpDriver.sln

@@ -1,7 +1,7 @@
 
 Microsoft Visual Studio Solution File, Format Version 12.00
 # Visual Studio 2013
-VisualStudioVersion = 12.0.30110.0
+VisualStudioVersion = 12.0.30501.0
 MinimumVisualStudioVersion = 10.0.40219.1
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "MongoDB.Bson", "MongoDB.Bson\MongoDB.Bson.csproj", "{0E9A3A2A-49CD-4F6C-847C-DC79B4B65CE6}"
 EndProject
@@ -68,6 +68,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Release Notes", "Release No
 		Release Notes\Release Notes v1.8.3.md = Release Notes\Release Notes v1.8.3.md
 		Release Notes\Release Notes v1.8.md = Release Notes\Release Notes v1.8.md
 		Release Notes\Release Notes v1.9.1.md = Release Notes\Release Notes v1.9.1.md
+		Release Notes\Release Notes v1.9.2.md = Release Notes\Release Notes v1.9.2.md
 		Release Notes\Release Notes v1.9.md = Release Notes\Release Notes v1.9.md
 	EndProjectSection
 EndProject

MongoDB.DriverUnitTests/ReadPreferenceTests.cs

@@ -49,7 +49,7 @@ public void TestGetHashCodeIsSameWhenEverythingIsTheSame()
                     new ReplicaSetTag("dc", "ny")
                 }
             };
-            var rp1 = new ReadPreference(ReadPreferenceMode.Nearest, tagSets1);
+            var readPreference1 = new ReadPreference(ReadPreferenceMode.Nearest, tagSets1);
 
             var tagSets2 = new List<ReplicaSetTagSet>()
             {
@@ -58,13 +58,13 @@ public void TestGetHashCodeIsSameWhenEverythingIsTheSame()
                     new ReplicaSetTag("dc", "ny")
                 }
             };
-            var rp2 = new ReadPreference(ReadPreferenceMode.Nearest, tagSets2);
+            var readPreference2 = new ReadPreference(ReadPreferenceMode.Nearest, tagSets2);
 
-            Assert.AreEqual(rp1.GetHashCode(), rp2.GetHashCode());
+            Assert.AreEqual(readPreference1.GetHashCode(), readPreference2.GetHashCode());
         }
 
         [Test]
-        public void TestGetHashCodeIsDifferentWhenTagsAreDifferent()
+        public void TestEquality()
         {
             var tagSets1 = new List<ReplicaSetTagSet>()
             {
@@ -73,22 +73,22 @@ public void TestGetHashCodeIsDifferentWhenTagsAreDifferent()
                     new ReplicaSetTag("dc", "ny")
                 }
             };
-            var rp1 = new ReadPreference(ReadPreferenceMode.Nearest, tagSets1);
+            var readPreference1 = new ReadPreference(ReadPreferenceMode.Nearest, tagSets1);
 
             var tagSets2 = new List<ReplicaSetTagSet>()
             {
                 new ReplicaSetTagSet
                 {
-                    new ReplicaSetTag("dc", "tx")
+                    new ReplicaSetTag("dc", "ny")
                 }
             };
-            var rp2 = new ReadPreference(ReadPreferenceMode.Nearest, tagSets2);
+            var readPreference2 = new ReadPreference(ReadPreferenceMode.Nearest, tagSets1);
 
-            Assert.AreNotEqual(rp1.GetHashCode(), rp2.GetHashCode());
+            Assert.AreEqual(readPreference1, readPreference2);
         }
 
         [Test]
-        public void TestEquality()
+        public void TestAreNotEqualWhenTagSetsAreDifferent()
         {
             var tagSets1 = new List<ReplicaSetTagSet>()
             {
@@ -97,7 +97,7 @@ public void TestEquality()
                     new ReplicaSetTag("dc", "ny")
                 }
             };
-            var rp1 = new ReadPreference(ReadPreferenceMode.Nearest, tagSets1);
+            var readPreference1 = new ReadPreference(ReadPreferenceMode.Nearest, tagSets1);
 
             var tagSets2 = new List<ReplicaSetTagSet>()
             {
@@ -106,9 +106,9 @@ public void TestEquality()
                     new ReplicaSetTag("dc", "ny")
                 }
             };
-            var rp2 = new ReadPreference(ReadPreferenceMode.Nearest, tagSets1);
+            var readPreference2 = new ReadPreference(ReadPreferenceMode.Nearest, tagSets1);
 
-            Assert.AreEqual(rp1, rp2);
+            Assert.AreEqual(readPreference1, readPreference2);
         }
     }
 }

MongoDB.DriverUnitTests/ReplicaSetTagSetTests.cs

@@ -38,22 +38,6 @@ public void TestGetHashCodeIsSameWhenTagsAreTheSame()
             Assert.AreEqual(tagSet1.GetHashCode(), tagSet2.GetHashCode());
         }
 
-        [Test]
-        public void TestGetHashCodeIsSameWhenTagsAreDifferent()
-        {
-            var tagSet1 = new ReplicaSetTagSet
-            {
-                new ReplicaSetTag("dc", "ny")
-            };
-
-            var tagSet2 = new ReplicaSetTagSet
-            {
-                new ReplicaSetTag("dc", "tx")
-            };
-
-            Assert.AreNotEqual(tagSet1.GetHashCode(), tagSet2.GetHashCode());
-        }
-
         [Test]
         public void TestAreEqualWhenTagsAreEqual()
         {