fix(NODE-6583): update to fixed BSON version #4338
Conversation
nbbeeken
changed the title
There was a problem hiding this comment.
This is waiting on mongodb/js-bson#740 to be merged and released.
| reject( | ||
| new MongoNetworkTimeoutError( | ||
| `Socket '${connectEvent}' timed out after ${(performance.now() - start) | 0}ms (connectTimeoutMS: ${connectTimeoutMS})` | ||
| ) | ||
| ); |
There was a problem hiding this comment.
I don't mind putting these all back, but if they were helpful to debug once I think they would be again.
| } | ||
| // Finally, now treat the resulting duplex stream as the | ||
| // socket over which we send and receive wire protocol messages: | ||
| return await makeSocket({ ...options, existingSocket, proxyHost: undefined }); |
There was a problem hiding this comment.
We probably want to keep this change. We should only convert the errors from Socks to our network errors, makeSocket will already throw the correct type, or if it doesn't we wouldn't know in the SOCKs case because we always convert.
Some "null access" error becomes a retryable network error only under socks 😅 could be confusing!
| /** | ||
| * The path to the MongoDB Node.js driver. | ||
| * This MUST be set to the directory the driver is installed in | ||
| * NOT the file "lib/index.js" that is the driver's export. | ||
| */ | ||
| const MONGODB_DRIVER_PATH = (() => { |
There was a problem hiding this comment.
Also happy to pull out all this revision/version stuff. I think I've adequately made it fail nicely when the files/env vars don't exist. Again, it provided value once so it could again.
| @@ -67,7 +129,7 @@ function initCollection() { | |||
|
|
|||
| function dropCollection() { | |||
| return this.collection.drop().catch(e => { | |||
| if (e.code !== MONGODB_ERROR_CODES.NamespaceNotFound) { | |||
| if (e.code !== 26 /* NamespaceNotFound */) { | |||
There was a problem hiding this comment.
This isn't public API so testing arbitrary driver versions made this difficult when only importing at the package level.
nbbeeken
force-pushed
the
NODE-6552-fix-perf-tests
branch
from
48b0a8d
to
679a05c
Compare
Description
What is changing?
Is there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript