DOP-4973: Allow tabs/language selector to be added directly to the content #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayangler
reviewed
Sep 11, 2024
rayangler
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stories/Links:
DOP-4973
Adds use of
:tabs-selector-position: mainpage option (see here as example) to specify that a tabs selector should be rendered in the main column as opposed to the right-hand side. Please check mobile, tablet, and desktop view to ensure that the selected tabs render 1) the correct content when different languages are selected and 2) in the right place.Also moves
makeChoicesfunction into own util to stop circular dependency 🙌Figma
Current Behavior:
Driver Connection
Run Atlas Search Queries
Staging Links:
Driver Connection (displays in main column)
Run Atlas Search Queries (still displays in right column - also ignore the "click me")
Notes:
README updates