Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DriverBench full_bson.json uses legacy binary type: #290

Open
daprahamian opened this issue Mar 8, 2018 · 4 comments
Open

DriverBench full_bson.json uses legacy binary type: #290

daprahamian opened this issue Mar 8, 2018 · 4 comments

Comments

@daprahamian
Copy link
Contributor

full_bson.json includes the following segment:

"BOQAeydE": {
  "$binary": "RWNVVkhUUmVsWEhzcnhxV25WdnVQTWFERUJMRFRrYmlOVUFGYmh3QWZzRGtTRkVHT1lrTWFKR2twUUFIZVVGWkJ1Y1RlYlpNTGF2VG51Vk8=",
  "$type": "00"
},

This is the legacy binary format, and should look something like:

"Binary": {
  "$binary": {
    "base64": "RWNVVkhUUmVsWEhzcnhxV25WdnVQTWFERUJMRFRrYmlOVUFGYmh3QWZzRGtTRkVHT1lrTWFKR2twUUFIZVVGWkJ1Y1RlYlpNTGF2VG51Vk8=",
    "subType": "03"
  }
},
@mbroadst
Copy link
Member

mbroadst commented Mar 9, 2018

/cc @xdg

@behackett
Copy link
Member

subtype 03 is for legacy UUID, not legacy generic binary.

@xdg
Copy link
Contributor

xdg commented Apr 12, 2018

I think he meant "legacy extended json binary type" -- but in the second example I think it should be subtype 0, not 03 for consistency. The keys are different (and in a subdoc) but the content is the same.

@daprahamian
Copy link
Contributor Author

I actually wound up using subtype 0 in #291.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants