Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace request ip with Cf-Connecting-Ip value #284

Merged
merged 1 commit into from
Mar 10, 2024
Merged

feat: replace request ip with Cf-Connecting-Ip value #284

merged 1 commit into from
Mar 10, 2024

Conversation

asbiin
Copy link
Member

@asbiin asbiin commented Mar 10, 2024

No description provided.

@asbiin asbiin changed the title Replace request ip with Cf-Connecting-Ip value feat: replace request ip with Cf-Connecting-Ip value Mar 10, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@asbiin asbiin merged commit 4e760aa into main Mar 10, 2024
22 checks passed
@asbiin asbiin deleted the cf-connecting-ip branch March 10, 2024 17:30
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@RobertBoes
Copy link

I don't exactly know why, but this PR seems to have broken my trusted proxies, and thus Laravel not detecting it's being served through https.

Since it was a minor version I upgraded it, which caused generated URLs to be http://domain.com instead of HTTPS. I'm using CloudFlare to proxy HTTPS to HTTP on my server. Updating the default LARAVEL_CLOUDFLARE_REPLACE_IP to false fixes the issue. Seems kinda strange to introduce a behavioral change in a minor release with the new behaviour now being default.

@asbiin
Copy link
Member Author

asbiin commented Mar 30, 2024

@RobertBoes I'm sorry, I didn't expected to introduce a disruption, obviously. I will change the default of LARAVEL_CLOUDFLARE_REPLACE_IP to false, and find a better approach...

@asbiin asbiin mentioned this pull request Mar 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asbiin @RobertBoes