Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monica API Doc has Invalid JSON example for Contact Creation #571

Open
ChrisKibble opened this issue Oct 3, 2021 · 1 comment
Open

Monica API Doc has Invalid JSON example for Contact Creation #571

ChrisKibble opened this issue Oct 3, 2021 · 1 comment

Comments

@ChrisKibble
Copy link

https://www.monicahq.com/api/contacts#create-a-contact

Current published example:

{
  "first_name": "henri",
  "last_name": "troyat",
  "nickname": "Rambo",
  "gender_id": 1,
  "birthdate_day": null,
  "birthdate_month": null,
  "birthdate_year": null,
  "is_birthdate_known": false,
  "birthdate_is_age_based": true,
  "is_birthdate_known": false,
  "birthdate_age": 29,
  "is_partial": false,
  "is_deceased": true,
  "deceased_date_day": 2,
  "deceased_date_month": 2,
  "deceased_date_year": 2017,
  "deceased_date_is_age_based": false,
  "is_deceased_date_known": true,
}

Problems:

  • Last entry is_deceased_date_known has a trailing comma that needs to be removed.
  • The entry is_birthdate_known is listed twice, one needs to be removed.

Suggested example:

{
	"first_name": "henri",
	"last_name": "troyat",
	"nickname": "Rambo",
	"gender_id": 1,
	"birthdate_day": null,
	"birthdate_month": null,
	"birthdate_year": null,
	"is_birthdate_known": false,
	"birthdate_is_age_based": true,
	"birthdate_age": 29,
	"is_partial": false,
	"is_deceased": true,
	"deceased_date_day": 2,
	"deceased_date_month": 2,
	"deceased_date_year": 2017,
	"deceased_date_is_age_based": false
}
@Mehdiben1986
Copy link

True and correct

@asbiin asbiin transferred this issue from monicahq/monica Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants