Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required groups vs Number of reviewers #50

Open
albertdabrowski opened this issue Jul 26, 2016 · 2 comments
Open

Required groups vs Number of reviewers #50

albertdabrowski opened this issue Jul 26, 2016 · 2 comments

Comments

@albertdabrowski
Copy link

We have 2 groups let's say A and B and want to say that we wanna have at least one PR approval from each group.
Currently if I have let's say 2 users in group A and get approvals from those 2 then it's enough.
Would it be possible to provide such logic so we require at least one approval from each required groups?

@ghost
Copy link

ghost commented May 16, 2018

@albertdabrowski did you find a work around?

@albertdabrowski
Copy link
Author

No. Due to this we decided to not use pr-harmony at all. So for us it is important to have at least one approval from one group (admins).
So we changed:

  • branch permissions
  • "default reviewers" feature in BB to only those with branch permissions and set required approvals to 1 from that group of people
    So only person from that default reviewer may merge. Long way from ideal but enough for current needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant