Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impr(language): russian list improvements (@psq4) #6074

Merged
merged 13 commits into from
Jan 13, 2025
Merged

impr(language): russian list improvements (@psq4) #6074

merged 13 commits into from
Jan 13, 2025

Conversation

psq4
Copy link
Contributor

@psq4 psq4 commented Nov 26, 2024

Description

Minor changes to Russian and Russian 1k (+ordering by frequency), added Russian 5k, contractions, contractions 1k, abbreviations

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • [ yes ] Adding a language or a theme?
    • [ yes ] If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #

psq4 added 8 commits November 26, 2024 17:14
@psq4
Update russian.json
a1550ac 
Zipf-ified the list (the words are now sorted by frequency), added the most frequent missing words to match the required minimum of 200 words per wordlist
@psq4
Update russian_1k.json
1c2adbd 
Zipf-ified the list, added capital letters to the start of proper nouns, added "ё" where needed
@psq4
Create russian_5k.json
211e57a 
Added Russian 5k
@psq4
Create russian_abbreviations.json
a00e24e 
Added Russian abbreviations
@psq4
Create russian_contractions.json
1cea64e 
Added Russian contractions (200 words)
@psq4
Create russian_contractions_1k.json
e285069 
Added Russian contractions 1k
@psq4
Update _groups.json
0476942 
Added new languages
@psq4
Update _list.json
d3d2a27 
Added new languages
@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Nov 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

This PR is stale. Please trigger a re-run of the PR check action.

@github-actions github-actions bot added the Stale Has not been updated in a while label Dec 3, 2024
@Miodec Miodec changed the title feat: russian changes (@psq4) impr(language): russian list improvements (@psq4) Dec 4, 2024
@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Dec 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions bot removed the Stale Has not been updated in a while label Dec 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR is stale. Please trigger a re-run of the PR check action.

@github-actions github-actions bot added the Stale Has not been updated in a while label Dec 12, 2024
@Miodec
Copy link
Member

Miodec commented Jan 2, 2025

Please fix build issues.

@Miodec Miodec removed the Stale Has not been updated in a while label Jan 2, 2025
@psq4
Copy link
Contributor Author

psq4 commented Jan 4, 2025

Please fix build issues.

What exactly is needed to be done? Sorry, I quite literally know nothing about programming and stuff, so I don't understand what causes said issues

@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Jan 4, 2025
@Miodec
Copy link
Member

Miodec commented Jan 4, 2025

If you open the logs from the failing check, you will see that the 5k list is not formatted correctly: https://github.com/monkeytypegame/monkeytype/actions/runs/12032824097/job/33917926134#step:7:16

Probably you misplaced a space somewhere.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@psq4
Update russian_1k.json
df04673 
removed duplicates
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@psq4
Update russian_5k.json
5c5889d 
removed duplicates
Miodec
Miodec approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Miodec Miodec merged commit af64388 into monkeytypegame:master Jan 13, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miodec Miodec Miodec approved these changes

Assignees
No one assigned
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@psq4 @Miodec @monkeytypegeorge