Added SKCanvas.DrawPoints with Count Override #2987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…point array drawing.
|
Hey there @DJGosnell! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
DJGosnell
changed the title
|
@dotnet-policy-service agree |
mattleibow
reviewed
Sep 3, 2024
There was a problem hiding this comment.
This is good. Maybe also throw an out of range exception if the count is negative or greater than the length of the array. Maybe also have a start index? This way it can be used in a sort of batch draw?
It may also be nice if you just added an ReadOnlySpan overload here too and then it will make the whole PR all nice. If you do that, then you can make both array overloads just use the span overload with a subset span of the whole array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Sometimes it's useful to pass an array of points to
SKCanvas.DrawPointsbut not to draw all of them. The API currently doesn't accept Spans at this point, so it is a stop-gap until that decision has been made.No tests added currently as there is not currently a test in the
tests/Tests/SkiaSharp/SKCanvasTest.csfile for drawing points.Bugs Fixed
API Changes
Add
public void SKCanvasDrawPoints (SKPointMode mode, SKPoint[] points, int count, SKPaint paint)overload.Behavioral Changes
None.
Required skia PR
None.
PR Checklist