-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next release with required pango dependency by default #688
Comments
Meanwhile, I have upgraded few libgdiplus packages with pango support:
we can remove the patch I used from master branch, once next release tag is available. |
Building without The option was merely left there for backward compatibility. |
Cool. Downstream packages still need to add pango in list of dependencies, as they are/were building with cairo. Error with opt-out arg would make the intent clear. |
From homebrew CI logs, before the PR:
current master (after the PR which added
|
Most libgdiplus packages are built without
--with-pango
and .NET users are forced to build the library from source to get the advanced typography features working. This need for building from source is not obvious to the end users (there are multiple issues in dotnet/runtime repo attesting to that) or the package maintainers.Back in 2018, some package management systems were having
pango < v1.38
and therefore marking the pango dependency mandatory for libgdiplus (which at the time worked withpango >= v1.38
) was not feasible: #269 (comment).However, now the situation (based on my research) is so; all relevant packaging systems with libgdiplus v6x also have
pango > 1.40
. Distros, such as Ubuntu 18.04, which have older pango are also not upgrading libgdiplus for some time (bionic is still having libgdiplus v4x). Later versions of Ubuntu have both pango 1.4x and libgdiplus v6x. Therefore marking pango as required dependency is safe.Suggestion for next libgdiplus version:
--with-pango
argument.--with-pango
argument is provided during configure:Remove `--with-pango` as pango is now a required dependency.
--without-pango
argument with a*WARNING* - some typrography / text rendering features will not work without pango. Consider removing `--without-pango` and adding the dependency.
The text was updated successfully, but these errors were encountered: