Don't draw the stroke when filling a path #668
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When filling a
GraphicsPath
, a 1px stroke is also drawn. From the comment and related commits it seems that this behaviour was needed at some stage in the past, but my testing shows that it is no longer correct.Test case (in Form Paint event):
Unmodified:
With this change:
For good measure, .Net Framework on Windows 8.1:
As you can see above, it really messes up drawing text or anything narrow via a
GraphicsPath
.After this change
fill_graphics_with_brush
is never called withstroke
set toTRUE
so I guess the parameter and code for drawing the stroke should be removed, but I didn't want to add that much noise initially.