Skip to content
This repository has been archived by the owner on Sep 4, 2024. It is now read-only.

Allow IAssemblyReflector to be properly disposable #110

Open
KirillOsenkov opened this issue Apr 13, 2018 · 2 comments
Open

Allow IAssemblyReflector to be properly disposable #110

KirillOsenkov opened this issue Apr 13, 2018 · 2 comments

Comments

@KirillOsenkov
Copy link
Member

On a Mac the default open file limit is 256. You can workaround it by using ulimit -S -n 24000. However we think Mono.Addins is not disposing of handles created by a Cecil-based implementation of IAssemblyReflector.

If my understanding of this is correct, we should probably make IAssemblyReflector inherit IDisposable and properly call Dispose() on it when we're done.

http://source.monodevelop.com/#Mono.Addins/Mono.Addins.Database/IAssemblyReflector.cs,41
http://source.monodevelop.com/#MonoDevelop.Addins.Tasks/AddinTask.cs,80

@KirillOsenkov
Copy link
Member Author

This is low-priority because we can work around by raising ulimit.

@KirillOsenkov
Copy link
Member Author

I have a workaround on the AddinMaker side:
mhutch/MonoDevelop.AddinMaker#67

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant