Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctrl-c doesn't exit for several seconds #164

Open
ns-cweber opened this issue Dec 12, 2016 · 4 comments
Open

ctrl-c doesn't exit for several seconds #164

ns-cweber opened this issue Dec 12, 2016 · 4 comments

Comments

@ns-cweber
Copy link

ns-cweber commented Dec 12, 2016

When I'm searching a large directory with many subdirectories and decide to cancel my search via ctrl-c, the operation hangs for 10-30s (presumably correlated to the number and size of search files). This is a real usability pain point.

OS: OS X 10.11.6
Go version: go version go1.7.1 darwin/amd64
Reproduction instructions:

  1. Clone https://github.com/golang/go
  2. cd into the repo
  3. time pt golang and immediately ctrl+c
  4. Observe 6+ seconds before the operation terminates

Repeating the same steps with ag shows a .2 second termination time, and that's probably mostly the time it takes me to press ctrl+c.

@syohex
Copy link
Contributor

syohex commented Dec 14, 2016

[NOTE] the platinum searcher does not handle any signals.

  • Your environment, OS, go version etc
  • How to reproduce this issue ? (Searching for Linux kernel tree ?)

@ns-cweber
Copy link
Author

I've updated the original issue.

@syohex
Copy link
Contributor

syohex commented Dec 15, 2016

I cannot reproduce. It looks you use older Go. Could you try again after updating go and re-compiling the platinum searcher.

My Environment is

  • Go : go version go1.7.4 darwin/amd64
  • OS : macOS 10.11.6
  • Latest the platinum searcher built from source code.

@ns-cweber
Copy link
Author

ns-cweber commented Dec 15, 2016

No change. :(

My pt commit sha is 509368a if that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants